Source/core/page/DOMSelection.cpp - Issue 252783002: Make Range.detach() a no-op

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/DOMSelection.cpp

Issue 252783002: Make Range.detach() a no-op (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fix some failures Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/page/DOMSelection.cpp

diff --git a/Source/core/page/DOMSelection.cpp b/Source/core/page/DOMSelection.cpp

index ebde68e61b0aabacef172ce9208df35978b90f7a..709dd6305b2d92f895919cdb891b6c6575427f9a 100644

--- a/Source/core/page/DOMSelection.cpp

+++ b/Source/core/page/DOMSelection.cpp

@@ -453,7 +453,7 @@ void DOMSelection::deleteFromDocument()

selectedRange->deleteContents(ASSERT_NO_EXCEPTION);

- setBaseAndExtent(selectedRange->startContainer(ASSERT_NO_EXCEPTION), selectedRange->startOffset(), selectedRange->startContainer(), selectedRange->startOffset(), ASSERT_NO_EXCEPTION);

+ setBaseAndExtent(selectedRange->startContainer(), selectedRange->startOffset(), selectedRange->startContainer(), selectedRange->startOffset(), ASSERT_NO_EXCEPTION);

}

bool DOMSelection::containsNode(const Node* n, bool allowPartial) const

« Source/core/frame/UseCounter.cpp ('K') | « Source/core/frame/UseCounter.cpp ('k') | Source/web/ContextMenuClientImpl.cpp » ('j') | no next file with comments »