Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Unified Diff: Source/core/dom/Range.idl

Issue 252783002: Make Range.detach() a no-op (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix some failures Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/dom/Range.idl
diff --git a/Source/core/dom/Range.idl b/Source/core/dom/Range.idl
index 83222a2c4ffcaa1062915a0f223e28be6734718d..93b3ce1b8eb1fa8b268bb304087bff7c2ff7f641 100644
--- a/Source/core/dom/Range.idl
+++ b/Source/core/dom/Range.idl
@@ -25,12 +25,12 @@
WillBeGarbageCollected,
] interface Range {
- [RaisesException=Getter] readonly attribute Node startContainer;
- [RaisesException=Getter] readonly attribute long startOffset;
- [RaisesException=Getter] readonly attribute Node endContainer;
- [RaisesException=Getter] readonly attribute long endOffset;
- [RaisesException=Getter] readonly attribute boolean collapsed;
- [RaisesException=Getter] readonly attribute Node commonAncestorContainer;
+ readonly attribute Node startContainer;
+ readonly attribute long startOffset;
+ readonly attribute Node endContainer;
+ readonly attribute long endOffset;
+ readonly attribute boolean collapsed;
+ readonly attribute Node commonAncestorContainer;
tkent 2014/04/28 08:50:50 nit: remove an extra whitespace
Inactive 2014/04/28 14:44:18 Done.
[RaisesException] void setStart(Node refNode, long offset);
[RaisesException] void setEnd(Node refNode, long offset);
@@ -38,7 +38,7 @@
[RaisesException] void setStartAfter(Node refNode);
[RaisesException] void setEndBefore(Node refNode);
[RaisesException] void setEndAfter(Node refNode);
- [RaisesException] void collapse([Default=Undefined] optional boolean toStart);
+ void collapse([Default=Undefined] optional boolean toStart);
[RaisesException] void selectNode(Node refNode);
[RaisesException] void selectNodeContents(Node refNode);
@@ -55,10 +55,10 @@
[RaisesException, CustomElementCallbacks] DocumentFragment cloneContents();
[RaisesException, CustomElementCallbacks] void insertNode(Node newNode);
[RaisesException, CustomElementCallbacks] void surroundContents(Node newParent);
- [RaisesException] Range cloneRange();
- [RaisesException] DOMString toString();
+ Range cloneRange();
+ DOMString toString();
- [RaisesException] void detach();
+ void detach();
[RaisesException] boolean isPointInRange(Node refNode, long offset);
[RaisesException] short comparePoint(Node refNode, long offset);

Powered by Google App Engine
This is Rietveld 408576698