Source/web/ContextMenuClientImpl.cpp - Issue 252783002: Make Range.detach() a no-op

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/ContextMenuClientImpl.cpp

Issue 252783002: Make Range.detach() a no-op (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebase Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/ContextMenuClientImpl.cpp

diff --git a/Source/web/ContextMenuClientImpl.cpp b/Source/web/ContextMenuClientImpl.cpp

index e4ad2db97f08e16f211457634a593940634795a4..330ed2f9a61c695d5e327eb768dcff6b89e02c98 100644

--- a/Source/web/ContextMenuClientImpl.cpp

+++ b/Source/web/ContextMenuClientImpl.cpp

@@ -165,7 +165,7 @@ static String selectMisspellingAsync(LocalFrame* selectedFrame, DocumentMarker&

marker = *markers[0];

// Cloning a range fails only for invalid ranges.

- RefPtrWillBeRawPtr<Range> markerRange = selectionRange->cloneRange(ASSERT_NO_EXCEPTION);

+ RefPtrWillBeRawPtr<Range> markerRange = selectionRange->cloneRange();

markerRange->setStart(markerRange->startContainer(), marker.startOffset());

markerRange->setEnd(markerRange->endContainer(), marker.endOffset());

« no previous file with comments | « Source/core/page/DOMSelection.cpp ('k') | Source/web/TextFinder.cpp » ('j') | no next file with comments »