Source/core/editing/TextIteratorTest.cpp - Issue 252783002: Make Range.detach() a no-op

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/TextIteratorTest.cpp

Issue 252783002: Make Range.detach() a no-op (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebase Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/editing/TextIteratorTest.cpp

diff --git a/Source/core/editing/TextIteratorTest.cpp b/Source/core/editing/TextIteratorTest.cpp

index e44acdaad555dc4852eafff88aa9f576d4cd67ad..9cc94a14a4802707ea4ec743a43e4bf045e3adce 100644

--- a/Source/core/editing/TextIteratorTest.cpp

+++ b/Source/core/editing/TextIteratorTest.cpp

@@ -489,8 +489,8 @@ TEST_F(TextIteratorTest, FindPlainTextInvalidTarget)

setBodyInnerHTML(bodyContent);

RefPtrWillBeRawPtr<Range> range = getBodyRange();

- RefPtrWillBeRawPtr<Range> expectedRange = range->cloneRange(ASSERT_NO_EXCEPTION);

- expectedRange->collapse(false, ASSERT_NO_EXCEPTION);

+ RefPtrWillBeRawPtr<Range> expectedRange = range->cloneRange();

+ expectedRange->collapse(false);

// A lone lead surrogate (0xDA0A) example taken from fuzz-58.

static const UChar invalid1[] = {

« no previous file with comments | « Source/core/editing/TextIterator.cpp ('k') | Source/core/editing/markup.cpp » ('j') | no next file with comments »