Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1233)

Side by Side Diff: Source/web/WebRange.cpp

Issue 252783002: Make Range.detach() a no-op (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/web/TextFinder.cpp ('k') | Source/web/mac/WebSubstringUtil.mm » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
68 } 68 }
69 69
70 int WebRange::endOffset() const 70 int WebRange::endOffset() const
71 { 71 {
72 return m_private->endOffset(); 72 return m_private->endOffset();
73 } 73 }
74 74
75 WebNode WebRange::startContainer(WebExceptionCode& exceptionCode) const 75 WebNode WebRange::startContainer(WebExceptionCode& exceptionCode) const
76 { 76 {
77 // FIXME: Create a wrapper class that just sets the internal int. 77 // FIXME: Create a wrapper class that just sets the internal int.
78 TrackExceptionState exceptionState; 78 RefPtr<Node> node(m_private->startContainer());
79 RefPtr<Node> node(m_private->startContainer(exceptionState)); 79 exceptionCode = 0;
80 exceptionCode = exceptionState.code();
81 return node.release(); 80 return node.release();
82 } 81 }
83 82
84 WebNode WebRange::endContainer(WebExceptionCode& exceptionCode) const 83 WebNode WebRange::endContainer(WebExceptionCode& exceptionCode) const
85 { 84 {
86 // FIXME: Create a wrapper class that just sets the internal int. 85 // FIXME: Create a wrapper class that just sets the internal int.
87 TrackExceptionState exceptionState; 86 RefPtr<Node> node(m_private->endContainer());
88 RefPtr<Node> node(m_private->endContainer(exceptionState)); 87 exceptionCode = 0;
89 exceptionCode = exceptionState.code();
90 return node.release(); 88 return node.release();
91 } 89 }
92 90
93 WebString WebRange::toHTMLText() const 91 WebString WebRange::toHTMLText() const
94 { 92 {
95 return m_private->toHTML(); 93 return m_private->toHTML();
96 } 94 }
97 95
98 WebString WebRange::toPlainText() const 96 WebString WebRange::toPlainText() const
99 { 97 {
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
141 : m_private(range) 139 : m_private(range)
142 { 140 {
143 } 141 }
144 142
145 WebRange::operator PassRefPtrWillBeRawPtr<WebCore::Range>() const 143 WebRange::operator PassRefPtrWillBeRawPtr<WebCore::Range>() const
146 { 144 {
147 return m_private.get(); 145 return m_private.get();
148 } 146 }
149 147
150 } // namespace blink 148 } // namespace blink
OLDNEW
« no previous file with comments | « Source/web/TextFinder.cpp ('k') | Source/web/mac/WebSubstringUtil.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698