Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2527773002:
DevTools: separate array formatter from object formatter (Closed)
|
Created:
4 years ago by luoe Modified:
4 years ago Reviewers:
lushnikov CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDevTools: separate array formatter from object formatter
No visual or functional changes are presented in this CL. It separates the
_appendArrayPropertiesPreview() to prepare for moving array formatting logic
from printArrayResult(). The logic in printArrayResult() cannot be moved there
yet because it does not make use of the ObjectPreview, but it will do so in a
different CL.
BUG=666882
Committed: https://crrev.com/339d1441a7f5c27e48047e825384b734e26790c4
Cr-Commit-Position: refs/heads/master@{#435814}
Patch Set 1 #
Total comments: 4
Patch Set 2 : ac #Messages
Total messages: 18 (12 generated)
Description was changed from ========== DevTools: separate array format in preview formatter BUG=666882 ========== to ========== DevTools: separate array format in preview formatter No visual or functional changes are presented in this CL. It separates the _appendArrayPropertiesPreview() to prepare for moving array formatting logic from printArrayResult(). The logic in printArrayResult() cannot be moved there yet because it does not make use of the ObjectPreview, but it will do so in a different CL. BUG=666882 ==========
Description was changed from ========== DevTools: separate array format in preview formatter No visual or functional changes are presented in this CL. It separates the _appendArrayPropertiesPreview() to prepare for moving array formatting logic from printArrayResult(). The logic in printArrayResult() cannot be moved there yet because it does not make use of the ObjectPreview, but it will do so in a different CL. BUG=666882 ========== to ========== DevTools: separate array formatter from object formatter No visual or functional changes are presented in this CL. It separates the _appendArrayPropertiesPreview() to prepare for moving array formatting logic from printArrayResult(). The logic in printArrayResult() cannot be moved there yet because it does not make use of the ObjectPreview, but it will do so in a different CL. BUG=666882 ==========
luoe@chromium.org changed reviewers: + lushnikov@chromium.org
Please take a look at this refactoring change.
lgtm https://codereview.chromium.org/2527773002/diff/1/third_party/WebKit/Source/d... File third_party/WebKit/Source/devtools/front_end/components/RemoteObjectPreviewFormatter.js (right): https://codereview.chromium.org/2527773002/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/components/RemoteObjectPreviewFormatter.js:51: _appendPropertiesPreview(parentElement, preview) { _appendObjectPropertiesPreview https://codereview.chromium.org/2527773002/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/components/RemoteObjectPreviewFormatter.js:147: result.createTextChild(needsQuotes ? '"' + name.replace(/\n/g, '\u21B5') + '"' : name); why don't we use textContent?
https://codereview.chromium.org/2527773002/diff/1/third_party/WebKit/Source/d... File third_party/WebKit/Source/devtools/front_end/components/RemoteObjectPreviewFormatter.js (right): https://codereview.chromium.org/2527773002/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/components/RemoteObjectPreviewFormatter.js:51: _appendPropertiesPreview(parentElement, preview) { On 2016/11/23 23:56:39, lushnikov wrote: > _appendObjectPropertiesPreview Done. https://codereview.chromium.org/2527773002/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/components/RemoteObjectPreviewFormatter.js:147: result.createTextChild(needsQuotes ? '"' + name.replace(/\n/g, '\u21B5') + '"' : name); On 2016/11/23 23:56:39, lushnikov wrote: > why don't we use textContent? Done.
The CQ bit was checked by luoe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by luoe@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from lushnikov@chromium.org Link to the patchset: https://codereview.chromium.org/2527773002/#ps20001 (title: "ac")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480642483511810,
"parent_rev": "e5328790b520523bf3d9723b16ded6bcbbb4f620", "commit_rev":
"41be9768f4f7739f30de1b6cd6ba49c9c7889fb5"}
Message was sent while issue was closed.
Description was changed from ========== DevTools: separate array formatter from object formatter No visual or functional changes are presented in this CL. It separates the _appendArrayPropertiesPreview() to prepare for moving array formatting logic from printArrayResult(). The logic in printArrayResult() cannot be moved there yet because it does not make use of the ObjectPreview, but it will do so in a different CL. BUG=666882 ========== to ========== DevTools: separate array formatter from object formatter No visual or functional changes are presented in this CL. It separates the _appendArrayPropertiesPreview() to prepare for moving array formatting logic from printArrayResult(). The logic in printArrayResult() cannot be moved there yet because it does not make use of the ObjectPreview, but it will do so in a different CL. BUG=666882 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== DevTools: separate array formatter from object formatter No visual or functional changes are presented in this CL. It separates the _appendArrayPropertiesPreview() to prepare for moving array formatting logic from printArrayResult(). The logic in printArrayResult() cannot be moved there yet because it does not make use of the ObjectPreview, but it will do so in a different CL. BUG=666882 ========== to ========== DevTools: separate array formatter from object formatter No visual or functional changes are presented in this CL. It separates the _appendArrayPropertiesPreview() to prepare for moving array formatting logic from printArrayResult(). The logic in printArrayResult() cannot be moved there yet because it does not make use of the ObjectPreview, but it will do so in a different CL. BUG=666882 Committed: https://crrev.com/339d1441a7f5c27e48047e825384b734e26790c4 Cr-Commit-Position: refs/heads/master@{#435814} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/339d1441a7f5c27e48047e825384b734e26790c4 Cr-Commit-Position: refs/heads/master@{#435814} |
