Chromium Code Reviews| Index: third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js |
| diff --git a/third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js b/third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js |
| index 278654a05e978150fd2483b613547f15def07d59..9f4768ef117196d0d68b451850be8f4304c91678 100644 |
| --- a/third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js |
| +++ b/third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js |
| @@ -523,21 +523,22 @@ Elements.ElementsPanel = class extends UI.Panel { |
| * @return {!Element|!AnchorBox|undefined} |
| */ |
| _getPopoverAnchor(element, event) { |
| - var anchor = element.enclosingNodeOrSelfWithClass('webkit-html-resource-link'); |
|
lushnikov
2016/11/24 00:14:39
this is actually different. Does it work with imag
dgozman
2016/11/24 00:58:29
It works.
|
| - if (!anchor || !anchor.href) |
| - return; |
| - |
| - return anchor; |
| + var link = element; |
| + while (link && !link[Elements.ElementsTreeElement.HrefSymbol]) |
| + link = link.parentElementOrShadowHost(); |
| + return link ? link : undefined; |
| } |
| /** |
| - * @param {!Element} anchor |
| + * @param {!Element} link |
| * @param {!UI.Popover} popover |
| */ |
| - _showPopover(anchor, popover) { |
| + _showPopover(link, popover) { |
| var node = this.selectedDOMNode(); |
| - if (node) |
| - Components.DOMPresentationUtils.buildImagePreviewContents(node.target(), anchor.href, true, showPopover); |
| + if (node) { |
| + Components.DOMPresentationUtils.buildImagePreviewContents( |
| + node.target(), link[Elements.ElementsTreeElement.HrefSymbol], true, showPopover); |
| + } |
| /** |
| * @param {!Element=} contents |
| @@ -546,7 +547,7 @@ Elements.ElementsPanel = class extends UI.Panel { |
| if (!contents) |
| return; |
| popover.setCanShrink(false); |
| - popover.showForAnchor(contents, anchor); |
| + popover.showForAnchor(contents, link); |
| } |
| } |