|
Revert 266297 "1. Handle the case of empty embedder_extension_id..."
This change introduces static initializers (the two
static const std::string Type constants).
Static strings should be declared as char * instead.
> 1. Handle the case of empty embedder_extension_id in guestview.h.
>
> 2. Introduce a template class GuestView<T> to handle the *guestview-specific functions in guestview.h:
> . Rename GuestView to GuestViewBase, introduce GuestView<T> class, and move *ViewGuest-specific functions to GuestView<T>:
> -- FromWebContents<T>(...)
> -- From<T>(...).
> . Introduce a template member function As() in GuestViewBase to replace all of the As*View functions.
>
> 3. In each derived *ViewGuest class , e.g., WebViewGuest & AdViewGuest, define a static variable to show its view type (string).
>
>
> BUG= 351824
>
> Review URL: https://codereview.chromium.org/237533008
TBR=hanxi@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266313
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+29 lines, -2993 lines) |
Patch |
 |
M |
trunk/src/chrome/browser/chrome_content_browser_client.cc
|
View
|
|
6 chunks |
+21 lines, -18 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/browser/extensions/api/declarative/declarative_api.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/browser/extensions/api/webview/webview_api.h
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/browser/extensions/menu_manager.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/browser/geolocation/chrome_geolocation_permission_context.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
D |
trunk/src/chrome/browser/guest_view/OWNERS
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
D |
trunk/src/chrome/browser/guest_view/ad_view/ad_view_constants.h
|
View
|
|
1 chunk |
+0 lines, -19 lines |
0 comments
|
Download
|
 |
D |
trunk/src/chrome/browser/guest_view/ad_view/ad_view_constants.cc
|
View
|
|
1 chunk |
+0 lines, -13 lines |
0 comments
|
Download
|
 |
D |
trunk/src/chrome/browser/guest_view/ad_view/ad_view_guest.h
|
View
|
|
1 chunk |
+0 lines, -49 lines |
0 comments
|
Download
|
 |
D |
trunk/src/chrome/browser/guest_view/ad_view/ad_view_guest.cc
|
View
|
|
1 chunk |
+0 lines, -58 lines |
0 comments
|
Download
|
 |
D |
trunk/src/chrome/browser/guest_view/guest_view.h
|
View
|
|
1 chunk |
+0 lines, -38 lines |
0 comments
|
Download
|
 |
D |
trunk/src/chrome/browser/guest_view/guest_view_base.h
|
View
|
|
1 chunk |
+0 lines, -143 lines |
0 comments
|
Download
|
 |
D |
trunk/src/chrome/browser/guest_view/guest_view_base.cc
|
View
|
|
1 chunk |
+0 lines, -205 lines |
0 comments
|
Download
|
 |
D |
trunk/src/chrome/browser/guest_view/guest_view_constants.h
|
View
|
|
1 chunk |
+0 lines, -28 lines |
0 comments
|
Download
|
 |
D |
trunk/src/chrome/browser/guest_view/guest_view_constants.cc
|
View
|
|
1 chunk |
+0 lines, -22 lines |
0 comments
|
Download
|
 |
D |
trunk/src/chrome/browser/guest_view/web_view/context_menu_content_type_web_view.h
|
View
|
|
1 chunk |
+0 lines, -31 lines |
0 comments
|
Download
|
 |
D |
trunk/src/chrome/browser/guest_view/web_view/context_menu_content_type_web_view.cc
|
View
|
|
1 chunk |
+0 lines, -32 lines |
0 comments
|
Download
|
 |
D |
trunk/src/chrome/browser/guest_view/web_view/javascript_dialog_helper.h
|
View
|
|
1 chunk |
+0 lines, -53 lines |
0 comments
|
Download
|
 |
D |
trunk/src/chrome/browser/guest_view/web_view/javascript_dialog_helper.cc
|
View
|
|
1 chunk |
+0 lines, -104 lines |
0 comments
|
Download
|
 |
D |
trunk/src/chrome/browser/guest_view/web_view/plugin_permission_helper.h
|
View
|
|
1 chunk |
+0 lines, -48 lines |
0 comments
|
Download
|
 |
D |
trunk/src/chrome/browser/guest_view/web_view/plugin_permission_helper.cc
|
View
|
|
1 chunk |
+0 lines, -109 lines |
0 comments
|
Download
|
 |
D |
trunk/src/chrome/browser/guest_view/web_view/web_view_constants.h
|
View
|
|
1 chunk |
+0 lines, -89 lines |
0 comments
|
Download
|
 |
D |
trunk/src/chrome/browser/guest_view/web_view/web_view_constants.cc
|
View
|
|
1 chunk |
+0 lines, -83 lines |
0 comments
|
Download
|
 |
D |
trunk/src/chrome/browser/guest_view/web_view/web_view_find_helper.h
|
View
|
|
1 chunk |
+0 lines, -186 lines |
0 comments
|
Download
|
 |
D |
trunk/src/chrome/browser/guest_view/web_view/web_view_find_helper.cc
|
View
|
|
1 chunk |
+0 lines, -279 lines |
0 comments
|
Download
|
 |
D |
trunk/src/chrome/browser/guest_view/web_view/web_view_guest.h
|
View
|
|
1 chunk |
+0 lines, -323 lines |
0 comments
|
Download
|
 |
D |
trunk/src/chrome/browser/guest_view/web_view/web_view_guest.cc
|
View
|
|
1 chunk |
+0 lines, -1023 lines |
0 comments
|
Download
|
 |
D |
trunk/src/chrome/browser/guest_view/web_view/web_view_permission_types.h
|
View
|
|
1 chunk |
+0 lines, -30 lines |
0 comments
|
Download
|
 |
A + |
trunk/src/chrome/browser/guestview/OWNERS
|
View
|
|
0 chunks |
+-1 lines, --1 lines |
0 comments
|
Download
|
 |
A + |
trunk/src/chrome/browser/guestview/adview/adview_constants.h
|
View
|
|
0 chunks |
+-1 lines, --1 lines |
0 comments
|
Download
|
 |
A + |
trunk/src/chrome/browser/guestview/adview/adview_constants.cc
|
View
|
|
0 chunks |
+-1 lines, --1 lines |
0 comments
|
Download
|
 |
A + |
trunk/src/chrome/browser/guestview/adview/adview_guest.h
|
View
|
|
0 chunks |
+-1 lines, --1 lines |
0 comments
|
Download
|
 |
A + |
trunk/src/chrome/browser/guestview/adview/adview_guest.cc
|
View
|
|
0 chunks |
+-1 lines, --1 lines |
0 comments
|
Download
|
 |
A + |
trunk/src/chrome/browser/guestview/guestview.h
|
View
|
|
0 chunks |
+-1 lines, --1 lines |
0 comments
|
Download
|
 |
A + |
trunk/src/chrome/browser/guestview/guestview.cc
|
View
|
|
0 chunks |
+-1 lines, --1 lines |
0 comments
|
Download
|
 |
A + |
trunk/src/chrome/browser/guestview/guestview_constants.h
|
View
|
|
0 chunks |
+-1 lines, --1 lines |
0 comments
|
Download
|
 |
A + |
trunk/src/chrome/browser/guestview/guestview_constants.cc
|
View
|
|
0 chunks |
+-1 lines, --1 lines |
0 comments
|
Download
|
 |
A + |
trunk/src/chrome/browser/guestview/webview/context_menu_content_type_webview.h
|
View
|
|
0 chunks |
+-1 lines, --1 lines |
0 comments
|
Download
|
 |
A + |
trunk/src/chrome/browser/guestview/webview/context_menu_content_type_webview.cc
|
View
|
|
0 chunks |
+-1 lines, --1 lines |
0 comments
|
Download
|
 |
A + |
trunk/src/chrome/browser/guestview/webview/javascript_dialog_helper.h
|
View
|
|
0 chunks |
+-1 lines, --1 lines |
0 comments
|
Download
|
 |
A + |
trunk/src/chrome/browser/guestview/webview/javascript_dialog_helper.cc
|
View
|
|
0 chunks |
+-1 lines, --1 lines |
0 comments
|
Download
|
 |
A + |
trunk/src/chrome/browser/guestview/webview/plugin_permission_helper.h
|
View
|
|
0 chunks |
+-1 lines, --1 lines |
0 comments
|
Download
|
 |
A + |
trunk/src/chrome/browser/guestview/webview/plugin_permission_helper.cc
|
View
|
|
0 chunks |
+-1 lines, --1 lines |
0 comments
|
Download
|
 |
A + |
trunk/src/chrome/browser/guestview/webview/webview_constants.h
|
View
|
|
0 chunks |
+-1 lines, --1 lines |
0 comments
|
Download
|
 |
A + |
trunk/src/chrome/browser/guestview/webview/webview_constants.cc
|
View
|
|
0 chunks |
+-1 lines, --1 lines |
0 comments
|
Download
|
 |
A + |
trunk/src/chrome/browser/guestview/webview/webview_find_helper.h
|
View
|
|
0 chunks |
+-1 lines, --1 lines |
0 comments
|
Download
|
 |
A + |
trunk/src/chrome/browser/guestview/webview/webview_find_helper.cc
|
View
|
|
0 chunks |
+-1 lines, --1 lines |
0 comments
|
Download
|
 |
A + |
trunk/src/chrome/browser/guestview/webview/webview_guest.h
|
View
|
|
0 chunks |
+-1 lines, --1 lines |
0 comments
|
Download
|
 |
A + |
trunk/src/chrome/browser/guestview/webview/webview_guest.cc
|
View
|
|
0 chunks |
+-1 lines, --1 lines |
0 comments
|
Download
|
 |
A + |
trunk/src/chrome/browser/guestview/webview/webview_permission_types.h
|
View
|
|
0 chunks |
+-1 lines, --1 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/browser/renderer_context_menu/context_menu_content_type_factory.cc
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/browser/renderer_context_menu/render_view_context_menu.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/chrome_browser.gypi
|
View
|
|
2 chunks |
+22 lines, -23 lines |
0 comments
|
Download
|
Total messages: 2 (0 generated)
|