Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 2527723002: Disable flaky TransportSecurityStateTest.BuiltinCertPins on Android. (Closed)

Created:
4 years ago by Łukasz Anforowicz
Modified:
4 years ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable flaky TransportSecurityStateTest.BuiltinCertPins on Android. BUG=668008 TBR=rdsmith@chromium.org, rockot@chromium.org Committed: https://crrev.com/d0d5a2921f045da504fb1a8d4cfbcf89d8535ca5 Cr-Commit-Position: refs/heads/master@{#434245}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M net/http/transport_security_state_unittest.cc View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Łukasz Anforowicz
rdsmith@, I plan to TBR this CL that disables a flaky test on Android. rockot@ ...
4 years ago (2016-11-23 19:52:22 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2527723002/1
4 years ago (2016-11-23 19:53:31 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-23 20:57:40 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d0d5a2921f045da504fb1a8d4cfbcf89d8535ca5 Cr-Commit-Position: refs/heads/master@{#434245}
4 years ago (2016-11-23 21:00:52 UTC) #7
Randy Smith (Not in Mondays)
LGTM.
4 years ago (2016-11-23 21:01:44 UTC) #8
eroman
4 years ago (2016-11-23 22:44:38 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2524023003/ by eroman@chromium.org.

The reason for reverting is: This test should no longer be flaky on Android, as
we instead fail at the test-suite level when the device failed to set its clock
properly..

Powered by Google App Engine
This is Rietveld 408576698