Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 25277005: Move more framebuffer state out of ContextState and into FramebufferState. (Closed)

Created:
7 years, 2 months ago by kloveless
Modified:
7 years, 2 months ago
Reviewers:
piman
CC:
chromium-reviews, piman+watch_chromium.org, apatrick_chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Move more framebuffer state out of ContextState and into FramebufferState. This will us (in future CLs) to not pass in ContextState into FramebufferManager, but just the FramebufferState. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226374

Patch Set 1 #

Patch Set 2 : Fix lint error. #

Patch Set 3 : Changed nullptr to NULL. #

Patch Set 4 : Rebased onto head, in the hope this fix errors unrelated to my change. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -47 lines) Patch
M gpu/command_buffer/service/context_state.h View 1 chunk +0 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/framebuffer_manager.h View 1 chunk +6 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/framebuffer_manager.cc View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 2 3 13 chunks +44 lines, -41 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
kloveless
7 years, 2 months ago (2013-09-30 18:40:42 UTC) #1
piman
LGTM (apatrick@ isn't able to do reviews right now, you can send those to me ...
7 years, 2 months ago (2013-09-30 21:54:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kloveless@chromium.org/25277005/7001
7 years, 2 months ago (2013-09-30 21:59:27 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 2 months ago (2013-09-30 22:25:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kloveless@chromium.org/25277005/17001
7 years, 2 months ago (2013-10-01 17:00:57 UTC) #5
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 2 months ago (2013-10-01 17:09:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kloveless@chromium.org/25277005/38001
7 years, 2 months ago (2013-10-01 17:38:09 UTC) #7
commit-bot: I haz the power
7 years, 2 months ago (2013-10-02 01:04:41 UTC) #8
Message was sent while issue was closed.
Change committed as 226374

Powered by Google App Engine
This is Rietveld 408576698