Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 25277003: Remove obsolete preparser binary and tests. (Closed)

Created:
7 years, 2 months ago by Michael Starzinger
Modified:
7 years, 2 months ago
Reviewers:
danno
CC:
v8-dev
Visibility:
Public.

Description

Remove obsolete preparser binary. R=danno@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=17113

Patch Set 1 #

Patch Set 2 : Preserve test suite. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -763 lines) Patch
M Makefile View 1 chunk +2 lines, -2 lines 0 comments Download
M build/all.gyp View 1 chunk +0 lines, -1 line 0 comments Download
D include/v8-preparser.h View 1 chunk +0 lines, -84 lines 0 comments Download
D preparser/preparser.gyp View 1 chunk +0 lines, -58 lines 0 comments Download
D preparser/preparser-process.cc View 1 chunk +0 lines, -372 lines 0 comments Download
M src/d8.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M src/d8.cc View 1 4 chunks +11 lines, -2 lines 0 comments Download
D src/preparser-api.cc View 1 chunk +0 lines, -196 lines 0 comments Download
D src/v8preparserdll-main.cc View 1 chunk +0 lines, -39 lines 0 comments Download
D test/preparser/preparser.status View 1 1 chunk +9 lines, -0 lines 0 comments Download
D test/preparser/strict-identifiers.pyt View 1 1 chunk +4 lines, -4 lines 0 comments Download
D test/preparser/testcfg.py View 1 3 chunks +3 lines, -3 lines 0 comments Download
M tools/android-sync.sh View 1 1 chunk +0 lines, -1 line 0 comments Download
M tools/presubmit.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Michael Starzinger
7 years, 2 months ago (2013-09-30 16:44:24 UTC) #1
danno
As discussed, I like the removal a lot, but let's find a way to save ...
7 years, 2 months ago (2013-10-02 09:18:25 UTC) #2
Michael Starzinger
Preserved the test suite. PTAL.
7 years, 2 months ago (2013-10-02 12:04:18 UTC) #3
danno
lgtm
7 years, 2 months ago (2013-10-04 16:13:22 UTC) #4
Michael Starzinger
7 years, 2 months ago (2013-10-04 16:21:34 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r17113 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698