Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2527693002: Add flag use_corelib_source_files to control how dart_bootstrap and gen_snapshot load core librarie… (Closed)

Created:
4 years ago by siva
Modified:
4 years ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add flag use_corelib_source_files to control how dart_bootstrap and gen_snapshot load core libraries during the boot strap process. If this flag is true then an attempt is made to read the core library sources files and if not present fallsback to the source bits baked in the binary. By default the flag is false. BUG=#27860 R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/7d287b232bbe749e250b70d4ecdcf66c08fef0c1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -9 lines) Patch
M runtime/vm/bootstrap.cc View 2 chunks +19 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
siva
4 years ago (2016-11-23 17:51:53 UTC) #2
rmacnak
lgtm
4 years ago (2016-11-23 18:03:37 UTC) #3
siva
4 years ago (2016-11-23 18:26:10 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7d287b232bbe749e250b70d4ecdcf66c08fef0c1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698