Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 2527643002: Enable shared memory for field trials (Closed)

Created:
4 years ago by lawrencewu
Modified:
4 years ago
CC:
chromium-reviews, asvitkine+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M base/metrics/field_trial.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (8 generated)
lawrencewu
Third time's the charm, right?
4 years ago (2016-11-23 14:37:46 UTC) #2
Alexei Svitkine (slow)
lgtm
4 years ago (2016-11-23 15:22:51 UTC) #5
lawrencewu
looks like a flake, retrying On 2016/11/23 15:22:51, Alexei Svitkine (slow) wrote: > lgtm
4 years ago (2016-11-23 16:43:16 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2527643002/1
4 years ago (2016-11-23 16:43:42 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-23 19:14:47 UTC) #12
commit-bot: I haz the power
4 years ago (2016-11-23 19:18:43 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/db8a9220deabed531200e613a53d4fe6d87136d5
Cr-Commit-Position: refs/heads/master@{#434217}

Powered by Google App Engine
This is Rietveld 408576698