add has_element_in_any_list check in ElementAnimations::UpdateActivation

cc/animation/element_animations_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/animation/element_animations.h"
 
 #include "cc/animation/animation_delegate.h"
 #include "cc/animation/animation_events.h"
 #include "cc/animation/animation_host.h"
 #include "cc/animation/animation_id_provider.h"
@@ skipping 3615 matching lines @@
   EXPECT_FALSE(player_->IsPotentiallyAnimatingProperty(
       TargetProperty::OPACITY, ElementListType::PENDING));
   EXPECT_FALSE(player_->IsPotentiallyAnimatingProperty(
       TargetProperty::OPACITY, ElementListType::ACTIVE));
   EXPECT_FALSE(player_->IsCurrentlyAnimatingProperty(TargetProperty::OPACITY,
                                                      ElementListType::PENDING));
   EXPECT_FALSE(player_->IsCurrentlyAnimatingProperty(TargetProperty::OPACITY,
                                                      ElementListType::ACTIVE));
 }
 
+TEST_F(ElementAnimationsTest, UnregisterElementBeforePushProperties) {
+  CreateTestLayer(false, false);
+  AttachTimelinePlayerLayer();
+  EXPECT_EQ(0u, host_->active_element_animations_for_testing().size());
+
+  player_->AddAnimation(CreateAnimation(
+      std::unique_ptr<AnimationCurve>(new FakeFloatTransition(1.0, 1.f, 0.5f)),
+      2, TargetProperty::OPACITY));
+  EXPECT_EQ(1u, host_->active_element_animations_for_testing().size());
+
+  host_->UnregisterElement(element_id_, ElementListType::ACTIVE);

[loyso (OOO), 2016/11/28 00:05:53]

Please, introduce
void AnimationTimelinesTest::DestroyTestMainLayer(){
  client_.UnregisterElement(element_id_, ElementListType::ACTIVE);
}

next to
void AnimationTimelinesTest::CreateTestMainLayer()
to unregister main-thread test layer and mimic real-world scenario.
(And call it here).

We need to unregister that TestLayer for real.

[junchao.han, 2016/11/28 04:09:03]

Done.

+  EXPECT_EQ(0u, host_->active_element_animations_for_testing().size());
+
+  PushProperties();
+  EXPECT_EQ(0u, host_->active_element_animations_for_testing().size());
+  EXPECT_EQ(1u, host_impl_->active_element_animations_for_testing().size());

[loyso (OOO), 2016/11/27 23:38:53]

This should be 0 since we don't have any impl-side layers, I think.

[junchao.han, 2016/11/28 04:09:03]

Done.

+
+  host_impl_->AnimateLayers(kInitialTickTime);
+  EXPECT_EQ(0u, host_impl_->active_element_animations_for_testing().size());
+}
+
 }  // namespace
 }  // namespace cc