Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issue 2527533002: Add SSE and NEON intrinsics for WSOLA's MultiChannelDotProduct(). (Closed)

Created:
4 years, 1 month ago by DaleCurtis
Modified:
4 years, 1 month ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, posciak+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add SSE and NEON intrinsics for WSOLA's MultiChannelDotProduct(). When adapting 10 seconds of 192kHz stereo audio at a 2.0 playback rate, this provides a ~9x speedup on ARM and a ~3x speedup on X86. NEON: 24986ms -> 2695ms SSE: 3014ms -> 894ms No tests added since the existing tests verify this functionality correctly and it continues to pass as before. BUG=666813 TEST=n5x for ARM, z620 for X86. Committed: https://crrev.com/77fd2aecaa7e1db995e158fb095a72be385e333c Cr-Commit-Position: refs/heads/master@{#434036}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Zero initialize dot product for C version. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -2 lines) Patch
M media/filters/wsola_internals.cc View 1 2 chunks +52 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
DaleCurtis
4 years, 1 month ago (2016-11-22 21:27:03 UTC) #3
DaleCurtis
See sinc_resampler.cc for reviewing assistance since these operations are very similar.
4 years, 1 month ago (2016-11-22 21:27:32 UTC) #4
sandersd (OOO until July 31)
lgtm https://codereview.chromium.org/2527533002/diff/1/media/filters/wsola_internals.cc File media/filters/wsola_internals.cc (right): https://codereview.chromium.org/2527533002/diff/1/media/filters/wsola_internals.cc#newcode77 media/filters/wsola_internals.cc:77: // horizontal sum function, so we have to ...
4 years, 1 month ago (2016-11-22 22:13:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2527533002/20001
4 years, 1 month ago (2016-11-22 22:47:36 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-23 00:08:41 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-23 00:11:27 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/77fd2aecaa7e1db995e158fb095a72be385e333c
Cr-Commit-Position: refs/heads/master@{#434036}

Powered by Google App Engine
This is Rietveld 408576698