Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 2527523002: Implement 'displayName' for accessor and varaible elements in linker. (Closed)

Created:
4 years, 1 month ago by scheglov
Modified:
4 years, 1 month ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Implement 'displayName' for accessor and varaible elements in linker. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/f1f036f01869550a864439198f10692cd6bded8b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M pkg/analyzer/lib/src/summary/link.dart View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
4 years, 1 month ago (2016-11-22 20:29:46 UTC) #1
Brian Wilkerson
While this fixes the immediate bug, shouldn't we just implement displayName for every link class ...
4 years, 1 month ago (2016-11-22 20:35:22 UTC) #2
Paul Berry
lgtm
4 years, 1 month ago (2016-11-22 20:52:21 UTC) #3
scheglov
4 years, 1 month ago (2016-11-22 20:59:28 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f1f036f01869550a864439198f10692cd6bded8b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698