third_party/WebKit/Source/modules/shapedetection/ShapeDetector.h - Issue 2527503003: FaceDetector: Pass |options| to parent constructor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/shapedetection/ShapeDetector.h

Issue 2527503003: FaceDetector: Pass |options| to parent constructor (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/shapedetection/ShapeDetector.h

diff --git a/third_party/WebKit/Source/modules/shapedetection/ShapeDetector.h b/third_party/WebKit/Source/modules/shapedetection/ShapeDetector.h

index 66ee0d2e17692c3a296a2bc3147c2301c25a9691..dea93942d9c564ee7ef35a5f1355cfb526fcda5f 100644

--- a/third_party/WebKit/Source/modules/shapedetection/ShapeDetector.h

+++ b/third_party/WebKit/Source/modules/shapedetection/ShapeDetector.h

@@ -26,6 +26,7 @@ class MODULES_EXPORT ShapeDetector

// https://github.com/WICG/shape-detection-api/issues/6

};

explicit ShapeDetector(LocalFrame&);

+ explicit ShapeDetector(LocalFrame&, const FaceDetectorOptions&);

haraken 2016/11/23 01:37:33 Nit: Drop explicit.

virtual ~ShapeDetector() = default;

ScriptPromise detectShapes(ScriptState*,