Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1275)

Issue 2527503002: Revert of DevTools: all swatches should have a default focused element (Closed)

Created:
4 years, 1 month ago by luoe
Modified:
4 years ago
Reviewers:
kozy, dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of DevTools: all swatches should have a default focused element (patchset #4 id:60001 of https://codereview.chromium.org/2510883002/ ) Reason for revert: This introduced a color picker bug crbug.com/667739. To land, we need to fix the regression. Original issue's description: > DevTools: all swatches should have a default focused element > > Color swatches correctly respond to 'Enter' and 'Esc' because Spectrum calls > focus() whenever it loads. Bezier and shadow editors did not. This CL makes > bezier and shadow editors set a default focused element. SwatchPopoverHelper now > calls focus() after showing a view, instead of requiring each swatch-popover > implementation call focus. > > One peculiarity with color swatches is they may hide and show themselves after > loading a palette. To keep focus on the popover, focus restoring logic was added > to the SwatchPopoverHelper whenever hiding an old popover. > > BUG=665801 > > Committed: https://crrev.com/0384ce04d25ba97446b20e7ca2d423cec10c2ffd > Cr-Commit-Position: refs/heads/master@{#433382} TBR=dgozman@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=665801 Committed: https://crrev.com/7f89a2a5efbd41b83b66c8d18bea8eb9804e175b Cr-Commit-Position: refs/heads/master@{#434060}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -14 lines) Patch
M third_party/WebKit/Source/devtools/front_end/components/Spectrum.js View 3 chunks +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/BezierEditor.js View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/CSSShadowEditor.js View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/Popover.js View 2 chunks +3 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/SwatchPopoverHelper.js View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
luoe
Created Revert of DevTools: all swatches should have a default focused element
4 years, 1 month ago (2016-11-22 19:59:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2527503002/1
4 years, 1 month ago (2016-11-22 20:00:23 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 1 month ago (2016-11-22 20:00:25 UTC) #5
kozy
lgtm
4 years, 1 month ago (2016-11-22 20:57:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2527503002/1
4 years, 1 month ago (2016-11-22 20:58:37 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-23 01:12:38 UTC) #11
commit-bot: I haz the power
4 years ago (2016-11-23 01:17:33 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7f89a2a5efbd41b83b66c8d18bea8eb9804e175b
Cr-Commit-Position: refs/heads/master@{#434060}

Powered by Google App Engine
This is Rietveld 408576698