Chromium Code Reviews
DescriptionRevert of DevTools: all swatches should have a default focused element (patchset #4 id:60001 of https://codereview.chromium.org/2510883002/ )
Reason for revert:
This introduced a color picker bug crbug.com/667739. To land, we need to fix the regression.
Original issue's description:
> DevTools: all swatches should have a default focused element
>
> Color swatches correctly respond to 'Enter' and 'Esc' because Spectrum calls
> focus() whenever it loads. Bezier and shadow editors did not. This CL makes
> bezier and shadow editors set a default focused element. SwatchPopoverHelper now
> calls focus() after showing a view, instead of requiring each swatch-popover
> implementation call focus.
>
> One peculiarity with color swatches is they may hide and show themselves after
> loading a palette. To keep focus on the popover, focus restoring logic was added
> to the SwatchPopoverHelper whenever hiding an old popover.
>
> BUG=665801
>
> Committed: https://crrev.com/0384ce04d25ba97446b20e7ca2d423cec10c2ffd
> Cr-Commit-Position: refs/heads/master@{#433382}
TBR=dgozman@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=665801
Committed: https://crrev.com/7f89a2a5efbd41b83b66c8d18bea8eb9804e175b
Cr-Commit-Position: refs/heads/master@{#434060}
Patch Set 1 #
Messages
Total messages: 13 (6 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||