src/ports/SkImageDecoder_WIC.cpp - Issue 25275004: store SkAlphaType inside SkBitmap, on road to support unpremul

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ports/SkImageDecoder_WIC.cpp

Issue 25275004: store SkAlphaType inside SkBitmap, on road to support unpremul (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: remove occurances of setIsOpaque Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ports/SkImageDecoder_WIC.cpp

diff --git a/src/ports/SkImageDecoder_WIC.cpp b/src/ports/SkImageDecoder_WIC.cpp

index 7b2ae9e7ed6d06839a6bd9ccb055d8d00731f1eb..508c9d5092396873c9dfa6f765237bdc2ad4a698 100644

--- a/src/ports/SkImageDecoder_WIC.cpp

+++ b/src/ports/SkImageDecoder_WIC.cpp

@@ -222,7 +222,9 @@ bool SkImageDecoder_WIC::decodeStream(SkStream* stream, SkBitmap* bm, WICModes w

);

// Note: we don't need to premultiply here since we specified PBGRA

- bm->computeAndSetOpaquePredicate();

+ if (ComputeIsOpaque(*bm)) {

+ bm->setAlphaType(kOpaque_SkAlphaType);

+ }

}

return SUCCEEDED(hr);