src/images/SkImageDecoder_libbmp.cpp - Issue 25275004: store SkAlphaType inside SkBitmap, on road to support unpremul

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/images/SkImageDecoder_libbmp.cpp

Issue 25275004: store SkAlphaType inside SkBitmap, on road to support unpremul (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: remove occurances of setIsOpaque Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/images/SkImageDecoder_libbmp.cpp

diff --git a/src/images/SkImageDecoder_libbmp.cpp b/src/images/SkImageDecoder_libbmp.cpp

index 3eb181f781bc9d699d83a4c656003e3895fac700..2263d60145f21ace09c7ad9c2bdcbb929801624f 100644

--- a/src/images/SkImageDecoder_libbmp.cpp

+++ b/src/images/SkImageDecoder_libbmp.cpp

@@ -133,8 +133,8 @@ bool SkBMPImageDecoder::onDecode(SkStream* stream, SkBitmap* bm, Mode mode) {

SkScaledBitmapSampler sampler(width, height, getSampleSize());

- bm->setConfig(config, sampler.scaledWidth(), sampler.scaledHeight());

- bm->setIsOpaque(true);

+ bm->setConfig(config, sampler.scaledWidth(), sampler.scaledHeight(), 0,

+ kOpaque_SkAlphaType);

if (justBounds) {

return true;