samplecode/SampleTinyBitmap.cpp - Issue 25275004: store SkAlphaType inside SkBitmap, on road to support unpremul

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: samplecode/SampleTinyBitmap.cpp

Issue 25275004: store SkAlphaType inside SkBitmap, on road to support unpremul (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: samplecode/SampleTinyBitmap.cpp

diff --git a/samplecode/SampleTinyBitmap.cpp b/samplecode/SampleTinyBitmap.cpp

index 42866d07adfe6b370e7be9f4430fbfbfb6631dbd..dc7157ff99656c2bb135629dc626ffe8ddf93556 100644

--- a/samplecode/SampleTinyBitmap.cpp

+++ b/samplecode/SampleTinyBitmap.cpp

@@ -57,9 +57,8 @@ protected:

static void setBitmapOpaque(SkBitmap* bm, bool isOpaque) {

SkAutoLockPixels alp(*bm); // needed for ctable

- bm->setIsOpaque(isOpaque);

+ bm->setAlphaType(isOpaque ? kOpaque_SkAlphaType : kPremul_SkAlphaType);

#if 0

- // TODO - I think we just want to not allow this anymore

SkColorTable* ctable = bm->getColorTable();

if (ctable) {

ctable->setIsOpaque(isOpaque);