Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Issue 2527473002: Fix gen_snapshot product mode build (Closed)

Created:
4 years, 1 month ago by Cutch
Modified:
4 years, 1 month ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -9 lines) Patch
M runtime/bin/gen_snapshot.cc View 1 chunk +5 lines, -9 lines 0 comments Download
M runtime/include/dart_api.h View 1 chunk +7 lines, -0 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Cutch
4 years, 1 month ago (2016-11-22 19:34:12 UTC) #3
rmacnak
lgtm
4 years, 1 month ago (2016-11-22 19:35:15 UTC) #4
Cutch
4 years, 1 month ago (2016-11-22 19:35:33 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ed47486f6003eea8c6012d4ee1ea604c3dcd41f0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698