Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2527453002: Respect the "allowErrors" parameter in _ResynthesizeAstTest.checkLibrary. (Closed)

Created:
4 years, 1 month ago by Paul Berry
Modified:
4 years, 1 month ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Respect the "allowErrors" parameter in _ResynthesizeAstTest.checkLibrary. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/679e8fd9ff8a76b6e6944fdbc1f3c51d66a09a7b

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -14 lines) Patch
M pkg/analyzer/test/src/summary/resynthesize_ast_test.dart View 2 chunks +7 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_common.dart View 20 chunks +50 lines, -14 lines 2 comments Download

Messages

Total messages: 6 (2 generated)
Paul Berry
4 years, 1 month ago (2016-11-22 19:11:23 UTC) #2
scheglov
lgtm https://codereview.chromium.org/2527453002/diff/1/pkg/analyzer/test/src/summary/resynthesize_common.dart File pkg/analyzer/test/src/summary/resynthesize_common.dart (right): https://codereview.chromium.org/2527453002/diff/1/pkg/analyzer/test/src/summary/resynthesize_common.dart#newcode3259 pkg/analyzer/test/src/summary/resynthesize_common.dart:3259: print(f); It might be cleaner to filter out ...
4 years, 1 month ago (2016-11-22 19:13:24 UTC) #3
Paul Berry
Committed patchset #1 (id:1) manually as 679e8fd9ff8a76b6e6944fdbc1f3c51d66a09a7b (presubmit successful).
4 years, 1 month ago (2016-11-22 20:46:59 UTC) #5
Paul Berry
4 years, 1 month ago (2016-11-22 20:51:53 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/2527453002/diff/1/pkg/analyzer/test/src/summa...
File pkg/analyzer/test/src/summary/resynthesize_common.dart (right):

https://codereview.chromium.org/2527453002/diff/1/pkg/analyzer/test/src/summa...
pkg/analyzer/test/src/summary/resynthesize_common.dart:3259: print(f);
On 2016/11/22 19:13:24, scheglov wrote:
> It might be cleaner to filter out "unused X" errors at the point where we
check
> them.

Good point.  Done.

Powered by Google App Engine
This is Rietveld 408576698