src/accessors.cc - Issue 252743010: Check that JSArray::SetElementsLength does not throw in array.length accessor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/accessors.cc

Issue 252743010: Check that JSArray::SetElementsLength does not throw in array.length accessor. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/accessors.cc

diff --git a/src/accessors.cc b/src/accessors.cc

index ce8884af7b6310ffdb349ecd3591f7f3f5d75ba0..9b1b2410b8e349c290308887d8f8ee28d8e0c02a 100644

--- a/src/accessors.cc

+++ b/src/accessors.cc

@@ -197,9 +197,8 @@ void Accessors::ArrayLengthSetter(

}

if (uint32_v->Number() == number_v->Number()) {

- MaybeHandle<Object> result;

- result = JSArray::SetElementsLength(array_handle, uint32_v);

- USE(result);

+ maybe = JSArray::SetElementsLength(array_handle, uint32_v);

+ maybe.ToHandleChecked();

Yang 2014/04/29 12:45:58 Using .Check() should suffice.

return;

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »