Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 252743007: Remove kLogPluginMessages flag as part of flag cleanup (Closed)

Created:
6 years, 7 months ago by Aaron Boodman
Modified:
6 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Visibility:
Public.

Description

Remove kLogPluginMessages flag as part of flag cleanup. BUG=364781 R=jochen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268259

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -22 lines) Patch
M content/browser/plugin_process_host.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/gpu/gpu_channel.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/gpu/gpu_channel.cc View 5 chunks +0 lines, -13 lines 0 comments Download
M content/plugin/plugin_channel.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/plugin/plugin_channel.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Aaron Boodman
6 years, 7 months ago (2014-04-28 20:07:07 UTC) #1
jochen (gone - plz use gerrit)
would it make sense to leave the VLOG(1) calls in unconditionally? either way lgtm
6 years, 7 months ago (2014-04-29 08:01:54 UTC) #2
Aaron Boodman
The CQ bit was checked by aa@chromium.org
6 years, 7 months ago (2014-04-29 18:14:11 UTC) #3
Aaron Boodman
I don't think so. There will be too many of them. i think that nowadays ...
6 years, 7 months ago (2014-04-29 18:14:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aa@chromium.org/252743007/1
6 years, 7 months ago (2014-04-29 18:15:15 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 22:48:19 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium win_chromium_x64_rel on tryserver.chromium
6 years, 7 months ago (2014-04-29 22:48:19 UTC) #7
Aaron Boodman
The CQ bit was checked by aa@chromium.org
6 years, 7 months ago (2014-04-30 17:09:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aa@chromium.org/252743007/1
6 years, 7 months ago (2014-04-30 17:09:48 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-30 18:56:13 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel on tryserver.chromium
6 years, 7 months ago (2014-04-30 18:56:14 UTC) #11
Aaron Boodman
6 years, 7 months ago (2014-05-05 20:27:59 UTC) #12
Message was sent while issue was closed. 
Committed patchset #1 manually as r268259 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698