Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 252743006: Revert of Prepare browser_tests for data: urls being async (Closed)

Created:
6 years, 7 months ago by eseidel
Modified:
6 years, 7 months ago
Reviewers:
sky, abarth-chromium
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen (gone - plz use gerrit), dcheng
Visibility:
Public.

Description

Revert of Prepare browser_tests for data: urls being async (https://codereview.chromium.org/257723002/) Reason for revert: This didn't fully solve the issue, no need to add the complexity. Original issue's description: > Prepare browser_tests for data: urls being async > > RenderViewTest::LoadHTML assumed that issuing a load > of a data url, posting a task to quit the message loop > and then pumping the message loop until it quits was > sufficient to end up with a fully parsed page. > > That very soon won't be true once we send data: urls > to the threaded parser, as the parser thread posts > back to the main thread and may post tasks after the > quit message. > https://codereview.chromium.org/210253003/ > > Instead I've added a FrameLoadWaiter class which > implements RenderViewObserver to listen for the > load event for the frame and only post the quit > task once the load event had come in. > > BUG=308321 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266163 TBR=abarth@chromium.org,sky@chromium.org NOTREECHECKS=true NOTRY=true BUG=308321 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266607

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -23 lines) Patch
M content/public/test/render_view_test.cc View 1 chunk +3 lines, -23 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
eseidel
Created Revert of Prepare browser_tests for data: urls being async
6 years, 7 months ago (2014-04-28 18:09:23 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eseidel@chromium.org/252743006/1
6 years, 7 months ago (2014-04-28 18:10:19 UTC) #2
commit-bot: I haz the power
6 years, 7 months ago (2014-04-28 18:12:04 UTC) #3
Message was sent while issue was closed.
Change committed as 266607

Powered by Google App Engine
This is Rietveld 408576698