Source/core/css/parser/MediaConditionTest.cpp - Issue 252743004: A thread safe CSS calc parser for sizes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/parser/MediaConditionTest.cpp

Issue 252743004: A thread safe CSS calc parser for sizes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Revert last patch, will include it in a separate commit Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/parser/MediaConditionTest.cpp

diff --git a/Source/core/css/parser/MediaConditionTest.cpp b/Source/core/css/parser/MediaConditionTest.cpp

index 460992f5f4d0525b73c4b98e9fba2903cc7d6941..46985d38ad25605a913e63e4b17eb78585b67af2 100644

--- a/Source/core/css/parser/MediaConditionTest.cpp

+++ b/Source/core/css/parser/MediaConditionTest.cpp

@@ -41,7 +41,7 @@ TEST(MediaConditionParserTest, Basic)

for (unsigned i = 0; testCases[i].input; ++i) {

Vector<MediaQueryToken> tokens;

MediaQueryTokenizer::tokenize(testCases[i].input, tokens);

- TokenIterator endToken;

+ MediaQueryTokenIterator endToken;

// Stop the input once we hit a comma token

for (endToken = tokens.begin(); endToken != tokens.end() && endToken->type() != CommaToken; ++endToken) { }

RefPtrWillBeRawPtr<MediaQuerySet> mediaConditionQuerySet = MediaQueryParser::parseMediaCondition(tokens.begin(), endToken);