Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Unified Diff: Source/core/css/parser/SizesCalcParserTest.cpp

Issue 252743004: A thread safe CSS calc parser for sizes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Removed CSSCalc tests that assert Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/css/parser/SizesCalcParser.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/parser/SizesCalcParserTest.cpp
diff --git a/Source/core/css/parser/SizesCalcParserTest.cpp b/Source/core/css/parser/SizesCalcParserTest.cpp
new file mode 100644
index 0000000000000000000000000000000000000000..67a6f4d92c28afbb7086ad681daa2ec1a41cdb0e
--- /dev/null
+++ b/Source/core/css/parser/SizesCalcParserTest.cpp
@@ -0,0 +1,136 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "config.h"
+#include "core/css/parser/SizesCalcParser.h"
+
+#include "core/css/CSSPrimitiveValue.h"
+#include "core/css/MediaValuesCached.h"
+#include "core/css/StylePropertySet.h"
+#include "core/css/parser/MediaQueryTokenizer.h"
+
+#include <gtest/gtest.h>
+
+namespace WebCore {
+
+struct TestCase {
+ const char* input;
+ const unsigned output;
+ const bool valid;
+ const bool dontRunInCSSCalc;
+};
+
+static void initLengthArray(CSSLengthArray& lengthArray)
+{
+ lengthArray.resize(CSSPrimitiveValue::LengthUnitTypeCount);
+ for (size_t i = 0; i < CSSPrimitiveValue::LengthUnitTypeCount; ++i)
+ lengthArray.at(i) = 0;
+}
+
+static void verifyCSSCalc(String text, double value, bool valid, unsigned fontSize, unsigned viewportWidth, unsigned viewportHeight)
+{
+ CSSLengthArray lengthArray;
+ initLengthArray(lengthArray);
+ RefPtr<MutableStylePropertySet> propertySet = MutableStylePropertySet::create();
+ propertySet->setProperty(CSSPropertyLeft, text);
+ RefPtrWillBeRawPtr<CSSValue> cssValue = propertySet->getPropertyCSSValue(CSSPropertyLeft);
+ CSSPrimitiveValue* primitiveValue = toCSSPrimitiveValue(cssValue.get());
+ if (primitiveValue)
+ primitiveValue->accumulateLengthArray(lengthArray);
+ else
+ ASSERT_EQ(valid, false);
+ int length = lengthArray.at(CSSPrimitiveValue::UnitTypePixels);
+ length += lengthArray.at(CSSPrimitiveValue::UnitTypeFontSize) * fontSize;
+ length += lengthArray.at(CSSPrimitiveValue::UnitTypeViewportWidth) * viewportWidth / 100.0;
+ length += lengthArray.at(CSSPrimitiveValue::UnitTypeViewportHeight) * viewportHeight / 100.0;
+ ASSERT_EQ(value, length);
+}
+
+
+TEST(SizesCalcParserTest, Basic)
+{
+ TestCase testCases[] = {
+ {"calc(500px + 10em)", 660, true, false},
+ {"calc(500px + 2 * 10em)", 820, true, false},
+ {"calc(500px + 2*10em)", 820, true, false},
+ {"calc(500px + 0.5*10em)", 580, true, false},
+ {"calc(500px + (0.5*10em + 13px))", 593, true, false},
+ {"calc(100vw + (0.5*10em + 13px))", 593, true, false},
+ {"calc(100vh + (0.5*10em + 13px))", 736, true, false},
+ {"calc(100vh + calc(0.5*10em + 13px))", 736, true, true}, // CSSCalculationValue does not parse internal "calc(".
+ {"calc(100vh + (50%*10em + 13px))", 0, false, false},
+ {"calc(50em+13px)", 0, false, false},
+ {"calc(50em-13px)", 0, false, false},
+ {"calc(500px + 10)", 0, false, false},
+ {"calc(500 + 10)", 0, false, false},
+ {"calc(500px + 10s)", 0, false, true}, // This test ASSERTs in CSSCalculationValue.
+ {"calc(500px + 1cm)", 537, true, false},
+ {"calc(500px - 10s)", 0, false, true}, // This test ASSERTs in CSSCalculationValue.
+ {"calc(500px - 1cm)", 462, true, false},
+ {"calc(50px*10)", 500, true, false},
+ {"calc(50px*10px)", 0, false, false},
+ {"calc(50px/10px)", 0, false, false},
+ {"calc(500px/10)", 50, true, false},
+ {"calc(500/10)", 0, false, false},
+ {"calc(500px/0.5)", 1000, true, false},
+ {"calc(500px/.5)", 1000, true, false},
+ {"calc(500/0)", 0, false, false},
+ {"calc(500px/0)", 0, false, false},
+ {"calc(-500px/10)", 0, true, true}, // CSSCalculationValue does not clamp negative values to 0.
+ {"calc(((4) * ((10px))))", 40, true, false},
+ {"calc(50px / 0)", 0, false, false},
+ {"calc(50px / (10 + 10))", 2, true, false},
+ {"calc(50px / (10 - 10))", 0, false, false},
+ {"calc(50px / (10 * 10))", 0, true, false},
+ {"calc(50px / (10 / 10))", 50, true, false},
+ {"calc(200px*)", 0, false, false},
+ {"calc(+ +200px)", 0, false, false},
+ {"calc()", 0, false, false},
+ {"calc(100px + + +100px)", 0, false, false},
+ {"calc(200px 200px)", 0, false, false},
+ {"calc(100px * * 2)", 0, false, false},
+ {"calc(100px @ 2)", 0, false, false},
+ {"calc(1 flim 2)", 0, false, false},
+ {"calc(100px @ 2)", 0, false, false},
+ {"calc(1 flim 2)", 0, false, false},
+ {"calc(1 flim (2))", 0, false, false},
+ {0, 0, true, false} // Do not remove the terminator line.
+ };
+
+
+ MediaValuesCached::MediaValuesCachedData data;
+ data.viewportWidth = 500;
+ data.viewportHeight = 643;
+ data.deviceWidth = 500;
+ data.deviceHeight = 643;
+ data.devicePixelRatio = 2.0;
+ data.colorBitsPerComponent = 24;
+ data.monochromeBitsPerComponent = 0;
+ data.pointer = MediaValues::MousePointer;
+ data.defaultFontSize = 16;
+ data.threeDEnabled = true;
+ data.scanMediaType = false;
+ data.screenMediaType = true;
+ data.printMediaType = false;
+ data.strictMode = true;
+ RefPtr<MediaValues> mediaValues = MediaValuesCached::create(data);
+
+ for (unsigned i = 0; testCases[i].input; ++i) {
+ Vector<MediaQueryToken> tokens;
+ MediaQueryTokenizer::tokenize(testCases[i].input, tokens);
+ unsigned output;
+ bool valid = SizesCalcParser::parse(tokens.begin(), tokens.end(), mediaValues, output);
+ ASSERT_EQ(testCases[i].valid, valid);
+ if (valid)
+ ASSERT_EQ(testCases[i].output, output);
+ }
+
+ for (unsigned i = 0; testCases[i].input; ++i) {
+ if (testCases[i].dontRunInCSSCalc)
+ continue;
+ verifyCSSCalc(testCases[i].input, testCases[i].output, testCases[i].valid, data.defaultFontSize, data.viewportWidth, data.viewportHeight);
+ }
+}
+
+} // namespace
« no previous file with comments | « Source/core/css/parser/SizesCalcParser.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698