Source/core/css/parser/SizesAttributeParser.h - Issue 252743004: A thread safe CSS calc parser for sizes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/parser/SizesAttributeParser.h

Issue 252743004: A thread safe CSS calc parser for sizes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Review nits Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/parser/SizesAttributeParser.h

diff --git a/Source/core/css/parser/SizesAttributeParser.h b/Source/core/css/parser/SizesAttributeParser.h

index 52d34a6ae69da91ea38231b84da788cc0c13bb89..098753d631258085551d8a0461fdc7f0168a244d 100644

--- a/Source/core/css/parser/SizesAttributeParser.h

+++ b/Source/core/css/parser/SizesAttributeParser.h

@@ -25,9 +25,9 @@ private:

}

bool parse(Vector<MediaQueryToken>& tokens);

- bool parseMediaConditionAndLength(TokenIterator startToken, TokenIterator endToken);

+ bool parseMediaConditionAndLength(MediaQueryTokenIterator startToken, MediaQueryTokenIterator endToken);

unsigned effectiveSize();

- bool calculateLengthInPixels(TokenIterator startToken, TokenIterator endToken, unsigned& result);

+ bool calculateLengthInPixels(MediaQueryTokenIterator startToken, MediaQueryTokenIterator endToken, unsigned& result);

bool mediaConditionMatches(PassRefPtrWillBeRawPtr<MediaQuerySet> mediaCondition);

unsigned effectiveSizeDefaultValue();