Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Side by Side Diff: Source/core/css/parser/SizesAttributeParser.cpp

Issue 252743004: A thread safe CSS calc parser for sizes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Removed CSSCalc tests that assert Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/css/parser/SizesAttributeParser.h ('k') | Source/core/css/parser/SizesCalcParser.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "config.h" 5 #include "config.h"
6 #include "SizesAttributeParser.h" 6 #include "SizesAttributeParser.h"
7 7
8 #include "MediaTypeNames.h" 8 #include "MediaTypeNames.h"
9 #include "core/css/MediaQueryEvaluator.h" 9 #include "core/css/MediaQueryEvaluator.h"
10 #include "core/css/parser/MediaQueryTokenizer.h" 10 #include "core/css/parser/MediaQueryTokenizer.h"
11 11
12 namespace WebCore { 12 namespace WebCore {
13 13
14 unsigned SizesAttributeParser::findEffectiveSize(const String& attribute, PassRe fPtr<MediaValues> mediaValues) 14 unsigned SizesAttributeParser::findEffectiveSize(const String& attribute, PassRe fPtr<MediaValues> mediaValues)
15 { 15 {
16 Vector<MediaQueryToken> tokens; 16 Vector<MediaQueryToken> tokens;
17 SizesAttributeParser parser(mediaValues); 17 SizesAttributeParser parser(mediaValues);
18 18
19 MediaQueryTokenizer::tokenize(attribute, tokens); 19 MediaQueryTokenizer::tokenize(attribute, tokens);
20 if (!parser.parse(tokens)) 20 if (!parser.parse(tokens))
21 return parser.effectiveSizeDefaultValue(); 21 return parser.effectiveSizeDefaultValue();
22 return parser.effectiveSize(); 22 return parser.effectiveSize();
23 } 23 }
24 24
25 bool SizesAttributeParser::calculateLengthInPixels(TokenIterator startToken, Tok enIterator endToken, unsigned& result) 25 bool SizesAttributeParser::calculateLengthInPixels(MediaQueryTokenIterator start Token, MediaQueryTokenIterator endToken, unsigned& result)
26 { 26 {
27 MediaQueryTokenType type = startToken->type(); 27 MediaQueryTokenType type = startToken->type();
28 if (type == DimensionToken) { 28 if (type == DimensionToken) {
29 int length; 29 int length;
30 if (!CSSPrimitiveValue::isLength(startToken->unitType())) 30 if (!CSSPrimitiveValue::isLength(startToken->unitType()))
31 return false; 31 return false;
32 if ((m_mediaValues->computeLength(startToken->numericValue(), startToken ->unitType(), length)) && (length > 0)) { 32 if ((m_mediaValues->computeLength(startToken->numericValue(), startToken ->unitType(), length)) && (length > 0)) {
33 result = (unsigned)length; 33 result = (unsigned)length;
34 return true; 34 return true;
35 } 35 }
36 } 36 }
37 // FIXME - Handle calc() FunctionToken here! 37 // FIXME - Handle calc() FunctionToken here!
38 return false; 38 return false;
39 } 39 }
40 40
41 static void reverseSkipIrrelevantTokens(TokenIterator& token, TokenIterator star tToken) 41 static void reverseSkipIrrelevantTokens(MediaQueryTokenIterator& token, MediaQue ryTokenIterator startToken)
42 { 42 {
43 TokenIterator endToken = token; 43 MediaQueryTokenIterator endToken = token;
44 while (token != startToken && (token->type() == WhitespaceToken || token->ty pe() == CommentToken || token->type() == EOFToken)) 44 while (token != startToken && (token->type() == WhitespaceToken || token->ty pe() == CommentToken || token->type() == EOFToken))
45 --token; 45 --token;
46 if (token != endToken) 46 if (token != endToken)
47 ++token; 47 ++token;
48 } 48 }
49 49
50 static void reverseSkipUntilComponentStart(TokenIterator& token, TokenIterator s tartToken) 50 static void reverseSkipUntilComponentStart(MediaQueryTokenIterator& token, Media QueryTokenIterator startToken)
51 { 51 {
52 if (token == startToken) 52 if (token == startToken)
53 return; 53 return;
54 --token; 54 --token;
55 if (token->blockType() != MediaQueryToken::BlockEnd) 55 if (token->blockType() != MediaQueryToken::BlockEnd)
56 return; 56 return;
57 unsigned blockLevel = 0; 57 unsigned blockLevel = 0;
58 while (token != startToken) { 58 while (token != startToken) {
59 if (token->blockType() == MediaQueryToken::BlockEnd) { 59 if (token->blockType() == MediaQueryToken::BlockEnd) {
60 ++blockLevel; 60 ++blockLevel;
61 } else if (token->blockType() == MediaQueryToken::BlockStart) { 61 } else if (token->blockType() == MediaQueryToken::BlockStart) {
62 --blockLevel; 62 --blockLevel;
63 if (!blockLevel) 63 if (!blockLevel)
64 break; 64 break;
65 } 65 }
66 66
67 --token; 67 --token;
68 } 68 }
69 } 69 }
70 70
71 bool SizesAttributeParser::mediaConditionMatches(PassRefPtrWillBeRawPtr<MediaQue rySet> mediaCondition) 71 bool SizesAttributeParser::mediaConditionMatches(PassRefPtrWillBeRawPtr<MediaQue rySet> mediaCondition)
72 { 72 {
73 // FIXME: How do I handle non-screen media types here? 73 // FIXME: How do I handle non-screen media types here?
74 MediaQueryEvaluator mediaQueryEvaluator(MediaTypeNames::screen, *m_mediaValu es); 74 MediaQueryEvaluator mediaQueryEvaluator(MediaTypeNames::screen, *m_mediaValu es);
75 return mediaQueryEvaluator.eval(mediaCondition.get()); 75 return mediaQueryEvaluator.eval(mediaCondition.get());
76 } 76 }
77 77
78 bool SizesAttributeParser::parseMediaConditionAndLength(TokenIterator startToken , TokenIterator endToken) 78 bool SizesAttributeParser::parseMediaConditionAndLength(MediaQueryTokenIterator startToken, MediaQueryTokenIterator endToken)
79 { 79 {
80 TokenIterator lengthTokenStart; 80 MediaQueryTokenIterator lengthTokenStart;
81 TokenIterator lengthTokenEnd; 81 MediaQueryTokenIterator lengthTokenEnd;
82 82
83 reverseSkipIrrelevantTokens(endToken, startToken); 83 reverseSkipIrrelevantTokens(endToken, startToken);
84 lengthTokenEnd = endToken; 84 lengthTokenEnd = endToken;
85 reverseSkipUntilComponentStart(endToken, startToken); 85 reverseSkipUntilComponentStart(endToken, startToken);
86 lengthTokenStart = endToken; 86 lengthTokenStart = endToken;
87 unsigned length; 87 unsigned length;
88 if (!calculateLengthInPixels(lengthTokenStart, lengthTokenEnd, length)) 88 if (!calculateLengthInPixels(lengthTokenStart, lengthTokenEnd, length))
89 return false; 89 return false;
90 RefPtrWillBeRawPtr<MediaQuerySet> mediaCondition = MediaQueryParser::parseMe diaCondition(startToken, endToken); 90 RefPtrWillBeRawPtr<MediaQuerySet> mediaCondition = MediaQueryParser::parseMe diaCondition(startToken, endToken);
91 if (mediaCondition && mediaConditionMatches(mediaCondition)) { 91 if (mediaCondition && mediaConditionMatches(mediaCondition)) {
92 m_length = length; 92 m_length = length;
93 return true; 93 return true;
94 } 94 }
95 return false; 95 return false;
96 } 96 }
97 97
98 bool SizesAttributeParser::parse(Vector<MediaQueryToken>& tokens) 98 bool SizesAttributeParser::parse(Vector<MediaQueryToken>& tokens)
99 { 99 {
100 if (tokens.isEmpty()) 100 if (tokens.isEmpty())
101 return false; 101 return false;
102 TokenIterator startToken = tokens.begin(); 102 MediaQueryTokenIterator startToken = tokens.begin();
103 TokenIterator endToken; 103 MediaQueryTokenIterator endToken;
104 // Split on a comma token, and send the result tokens to be parsed as (media -condition, length) pairs 104 // Split on a comma token, and send the result tokens to be parsed as (media -condition, length) pairs
105 for (TokenIterator token = tokens.begin(); token != tokens.end(); ++token) { 105 for (MediaQueryTokenIterator token = tokens.begin(); token != tokens.end(); ++token) {
106 if (token->type() == CommaToken) { 106 if (token->type() == CommaToken) {
107 endToken = token; 107 endToken = token;
108 if (parseMediaConditionAndLength(startToken, endToken)) 108 if (parseMediaConditionAndLength(startToken, endToken))
109 return true; 109 return true;
110 startToken = token; 110 startToken = token;
111 ++startToken; 111 ++startToken;
112 } 112 }
113 } 113 }
114 endToken = tokens.end(); 114 endToken = tokens.end();
115 return parseMediaConditionAndLength(startToken, --endToken); 115 return parseMediaConditionAndLength(startToken, --endToken);
116 } 116 }
117 117
118 unsigned SizesAttributeParser::effectiveSize() 118 unsigned SizesAttributeParser::effectiveSize()
119 { 119 {
120 if (m_length) 120 if (m_length)
121 return m_length; 121 return m_length;
122 return effectiveSizeDefaultValue(); 122 return effectiveSizeDefaultValue();
123 } 123 }
124 124
125 unsigned SizesAttributeParser::effectiveSizeDefaultValue() 125 unsigned SizesAttributeParser::effectiveSizeDefaultValue()
126 { 126 {
127 // Returning the equivalent of "100%" 127 // Returning the equivalent of "100%"
128 return m_mediaValues->viewportWidth(); 128 return m_mediaValues->viewportWidth();
129 } 129 }
130 130
131 } // namespace 131 } // namespace
132 132
OLDNEW
« no previous file with comments | « Source/core/css/parser/SizesAttributeParser.h ('k') | Source/core/css/parser/SizesCalcParser.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698