Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 252743002: Update Virtual Keybaord icons. (Closed)

Created:
6 years, 8 months ago by rsadam
Modified:
6 years, 7 months ago
Reviewers:
bshe
CC:
chromium-reviews
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 5

Patch Set 2 : Remove old assets. #

Patch Set 3 : #

Patch Set 4 : Uprev. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -106 lines) Patch
M ui/keyboard/keyboard_resources.grd View 1 chunk +4 lines, -4 lines 0 comments Download
M ui/keyboard/keyboard_util.cc View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M ui/keyboard/resources/elements/kb-key.html View 2 chunks +3 lines, -4 lines 0 comments Download
M ui/keyboard/resources/elements/kb-key.js View 1 chunk +4 lines, -1 line 0 comments Download
A ui/keyboard/resources/images/backspace.png View Binary file 0 comments Download
D ui/keyboard/resources/images/backspace.svg View 1 1 chunk +0 lines, -17 lines 0 comments Download
A ui/keyboard/resources/images/hide-keyboard.png View Binary file 0 comments Download
D ui/keyboard/resources/images/hide-keyboard.svg View 1 1 chunk +0 lines, -14 lines 0 comments Download
A ui/keyboard/resources/images/return.png View Binary file 0 comments Download
D ui/keyboard/resources/images/return.svg View 1 1 chunk +0 lines, -16 lines 0 comments Download
A ui/keyboard/resources/images/tab.png View Binary file 0 comments Download
D ui/keyboard/resources/images/tab.svg View 1 1 chunk +0 lines, -20 lines 0 comments Download
M ui/keyboard/resources/layouts/qwerty.html View 1 2 3 9 chunks +16 lines, -12 lines 0 comments Download
M ui/keyboard/resources/layouts/system-qwerty.html View 8 chunks +11 lines, -8 lines 0 comments Download
M ui/keyboard/resources/main.css View 2 chunks +1 line, -6 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
rsadam
PTAL Biao! Adds most of the new assets. Will have a follow up patch for ...
6 years, 8 months ago (2014-04-25 19:03:00 UTC) #1
bshe
https://codereview.chromium.org/252743002/diff/1/ui/keyboard/keyboard_resources.grd File ui/keyboard/keyboard_resources.grd (right): https://codereview.chromium.org/252743002/diff/1/ui/keyboard/keyboard_resources.grd#newcode20 ui/keyboard/keyboard_resources.grd:20: <include name="IDR_KEYBOARD_IMAGES_BACKSPACE" file="resources/images/backspace.png" type="BINDATA" /> The old svg files ...
6 years, 8 months ago (2014-04-25 19:41:08 UTC) #2
rsadam
https://codereview.chromium.org/252743002/diff/1/ui/keyboard/keyboard_resources.grd File ui/keyboard/keyboard_resources.grd (right): https://codereview.chromium.org/252743002/diff/1/ui/keyboard/keyboard_resources.grd#newcode20 ui/keyboard/keyboard_resources.grd:20: <include name="IDR_KEYBOARD_IMAGES_BACKSPACE" file="resources/images/backspace.png" type="BINDATA" /> On 2014/04/25 19:41:08, bshe ...
6 years, 7 months ago (2014-04-28 15:23:14 UTC) #3
bshe
lgtm https://codereview.chromium.org/252743002/diff/1/ui/keyboard/keyboard_resources.grd File ui/keyboard/keyboard_resources.grd (right): https://codereview.chromium.org/252743002/diff/1/ui/keyboard/keyboard_resources.grd#newcode37 ui/keyboard/keyboard_resources.grd:37: <include name="IDR_KEYBOARD_IMAGES_SHIFT" file="resources/images/shift.svg" type="BINDATA" /> Sorry. I mean ...
6 years, 7 months ago (2014-04-28 15:51:59 UTC) #4
rsadam
Makes sense! Removed the shift asset.
6 years, 7 months ago (2014-04-28 15:57:18 UTC) #5
rsadam
The CQ bit was checked by rsadam@chromium.org
6 years, 7 months ago (2014-04-28 15:57:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsadam@chromium.org/252743002/30001
6 years, 7 months ago (2014-04-28 15:57:31 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 15:57:46 UTC) #8
commit-bot: I haz the power
Failed to request the patch to try. Please note that binary files are still unsupported ...
6 years, 7 months ago (2014-04-28 15:57:46 UTC) #9
rsadam
6 years, 7 months ago (2014-04-29 15:42:21 UTC) #10
Message was sent while issue was closed.
Committed patchset #4 manually as r266894 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698