Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 2527403002: Further encapsulate Enqueuer (Closed)

Created:
4 years ago by Johnni Winther
Modified:
4 years ago
Reviewers:
Harry Terkelsen
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Cleanup. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -89 lines) Patch
M pkg/compiler/lib/src/compiler.dart View 8 chunks +30 lines, -27 lines 0 comments Download
M pkg/compiler/lib/src/enqueue.dart View 1 11 chunks +54 lines, -36 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/enqueuer.dart View 5 chunks +8 lines, -24 lines 0 comments Download
M pkg/compiler/lib/src/universe/use.dart View 2 chunks +6 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/universe/world_builder.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/compiler/tool/perf.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/embedded_category_api_boundary_test.dart View 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
4 years ago (2016-11-25 15:10:01 UTC) #2
Harry Terkelsen
lgtm
4 years ago (2016-11-28 19:10:28 UTC) #3
Johnni Winther
4 years ago (2016-11-29 08:14:15 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
417d4d7a50ccabe35c404c05b423014d3e5dc608 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698