Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issue 2527393002: [LayoutNG] No need to search for inline children inside a block-children block. (Closed)

Created:
4 years ago by mstensho (USE GERRIT)
Modified:
4 years ago
Reviewers:
cbiesinger, atotic
CC:
chromium-reviews, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, glebl+reviews_chromium.org, atotic+reviews_chromium.org, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, zoltan1, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[LayoutNG] No need to search for inline children inside a block-children block. Also type-check that we're dealing with a LayoutBlockFlow before casting. Committed: https://crrev.com/d9063eddd283969fff799a39a43ad5ea0cdc78e7 Cr-Commit-Position: refs/heads/master@{#434968}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M third_party/WebKit/Source/core/layout/ng/ng_block_node.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
mstensho (USE GERRIT)
4 years ago (2016-11-25 14:16:02 UTC) #2
cbiesinger
lgtm
4 years ago (2016-11-28 22:56:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2527393002/1
4 years ago (2016-11-29 11:45:40 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-29 13:08:17 UTC) #7
commit-bot: I haz the power
4 years ago (2016-11-29 13:12:02 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d9063eddd283969fff799a39a43ad5ea0cdc78e7
Cr-Commit-Position: refs/heads/master@{#434968}

Powered by Google App Engine
This is Rietveld 408576698