Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issue 2527383002: Split //ios/public/provider/chrome/browser/* targets. (Closed)

Created:
4 years ago by sdefresne
Modified:
4 years ago
CC:
chromium-reviews, gcasto+watchlist_chromium.org, pkl (ping after 24h if needed), vabr+watchlistpasswordmanager_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Split //ios/public/provider/chrome/browser/* targets. BUG=658242 Committed: https://crrev.com/8f94e09f1d165e393e1f97a3f4b5cf722935f927 Cr-Commit-Position: refs/heads/master@{#434973}

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+298 lines, -95 lines) Patch
M ios/chrome/browser/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/browser_state/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M ios/chrome/browser/infobars/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/native_app_launcher/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
M ios/chrome/browser/passwords/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/providers/BUILD.gn View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M ios/chrome/browser/providers/images/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/sessions/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/signin/BUILD.gn View 3 chunks +4 lines, -1 line 0 comments Download
M ios/chrome/browser/translate/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/voice/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/voice/BUILD.gn View 3 chunks +3 lines, -2 lines 0 comments Download
D ios/provider/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
M ios/public/provider/chrome/browser/BUILD.gn View 2 chunks +35 lines, -90 lines 0 comments Download
A ios/public/provider/chrome/browser/distribution/BUILD.gn View 1 chunk +25 lines, -0 lines 0 comments Download
A ios/public/provider/chrome/browser/images/BUILD.gn View 1 chunk +25 lines, -0 lines 0 comments Download
A ios/public/provider/chrome/browser/native_app_launcher/BUILD.gn View 1 chunk +11 lines, -0 lines 0 comments Download
A ios/public/provider/chrome/browser/omaha/BUILD.gn View 1 1 chunk +26 lines, -0 lines 0 comments Download
A ios/public/provider/chrome/browser/sessions/BUILD.gn View 1 chunk +24 lines, -0 lines 0 comments Download
A ios/public/provider/chrome/browser/signin/BUILD.gn View 1 1 chunk +45 lines, -0 lines 0 comments Download
A ios/public/provider/chrome/browser/ui/BUILD.gn View 1 chunk +33 lines, -0 lines 0 comments Download
A ios/public/provider/chrome/browser/user_feedback/BUILD.gn View 1 chunk +25 lines, -0 lines 0 comments Download
M ios/public/provider/chrome/browser/voice/BUILD.gn View 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 32 (21 generated)
sdefresne
Please take a look.
4 years ago (2016-11-25 14:01:12 UTC) #4
sdefresne
Please take a look and send to CQ if LGTY.
4 years ago (2016-11-28 10:05:56 UTC) #10
sdefresne
=> rohitrao, PTAL.
4 years ago (2016-11-28 14:28:36 UTC) #14
rohitrao (ping after 24h)
lgtm
4 years ago (2016-11-28 16:19:56 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2527383002/20001
4 years ago (2016-11-28 16:20:16 UTC) #17
commit-bot: I haz the power
Failed to apply patch for ios/chrome/browser/providers/BUILD.gn: While running git apply --index -p1; error: patch failed: ...
4 years ago (2016-11-28 16:24:10 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2527383002/40001
4 years ago (2016-11-29 09:44:09 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/340178)
4 years ago (2016-11-29 12:09:21 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2527383002/40001
4 years ago (2016-11-29 12:10:16 UTC) #28
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-11-29 13:23:37 UTC) #30
commit-bot: I haz the power
4 years ago (2016-11-29 13:26:33 UTC) #32
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8f94e09f1d165e393e1f97a3f4b5cf722935f927
Cr-Commit-Position: refs/heads/master@{#434973}

Powered by Google App Engine
This is Rietveld 408576698