Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2527373003:
Stability execution phase: register shutdown timebomb state in quick exit path (Closed)
|
Created:
4 years ago by manzagop (departed) Modified:
4 years ago CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionStability execution phase: register shutdown timebomb state in quick exit path
The SHUTDOWN_TIMEBOMB_ARM execution phase was not set on the quick exit path
(SessionEnding).
BUG=668542
Committed: https://crrev.com/b5f74dbb3ccdc02be372cec383f3accd6b240f41
Cr-Commit-Position: refs/heads/master@{#434689}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Address comments #Messages
Total messages: 23 (14 generated)
The CQ bit was checked by manzagop@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
manzagop@chromium.org changed reviewers: + asvitkine@chromium.org
Please have a look!
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm https://codereview.chromium.org/2527373003/diff/1/chrome/browser/lifetime/app... File chrome/browser/lifetime/application_lifetime.cc (right): https://codereview.chromium.org/2527373003/diff/1/chrome/browser/lifetime/app... chrome/browser/lifetime/application_lifetime.cc:310: if (local_state) { Are you sure we need this if? If try bots pass without, suggest leaving it out.
The CQ bit was checked by manzagop@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Thanks for the review. https://codereview.chromium.org/2527373003/diff/1/chrome/browser/lifetime/app... File chrome/browser/lifetime/application_lifetime.cc (right): https://codereview.chromium.org/2527373003/diff/1/chrome/browser/lifetime/app... chrome/browser/lifetime/application_lifetime.cc:310: if (local_state) { On 2016/11/25 19:51:31, Alexei Svitkine (slow) wrote: > Are you sure we need this if? > > If try bots pass without, suggest leaving it out. Done.
manzagop@chromium.org changed reviewers: + jochen@chromium.org
Hi jochen@, Could you have an OWNERS' look? Thanks! Pierre
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
Thanks for the review!
The CQ bit was checked by manzagop@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from asvitkine@chromium.org Link to the patchset: https://codereview.chromium.org/2527373003/#ps20001 (title: "Address comments")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480343240002290,
"parent_rev": "7b2e6494fcf0d6a7a12ee75967626b3915effa0c", "commit_rev":
"67c24870d8c2db5f4e0b1e2728c6ad32ec44348b"}
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Stability execution phase: register shutdown timebomb state in quick exit path The SHUTDOWN_TIMEBOMB_ARM execution phase was not set on the quick exit path (SessionEnding). BUG=668542 ========== to ========== Stability execution phase: register shutdown timebomb state in quick exit path The SHUTDOWN_TIMEBOMB_ARM execution phase was not set on the quick exit path (SessionEnding). BUG=668542 Committed: https://crrev.com/b5f74dbb3ccdc02be372cec383f3accd6b240f41 Cr-Commit-Position: refs/heads/master@{#434689} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/b5f74dbb3ccdc02be372cec383f3accd6b240f41 Cr-Commit-Position: refs/heads/master@{#434689} |
