Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6639)

Unified Diff: chrome/browser/prerender/prerender_manager.cc

Issue 2527363002: Delete obsolete prerender experiment code (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prerender/prerender_manager.cc
diff --git a/chrome/browser/prerender/prerender_manager.cc b/chrome/browser/prerender/prerender_manager.cc
index 490684a2bf237e90434e51080637a16a3f18f8ba..53184efa2e44f62e7384b105f554192016b6ec14 100644
--- a/chrome/browser/prerender/prerender_manager.cc
+++ b/chrome/browser/prerender/prerender_manager.cc
@@ -182,19 +182,6 @@ PrerenderManager::PrerenderManager(Profile* profile)
GetCurrentTimeTicks() -
base::TimeDelta::FromMilliseconds(kMinTimeBetweenPrerendersMs);
- // Certain experiments override our default config_ values.
- switch (PrerenderManager::GetMode()) {
- case PrerenderManager::PRERENDER_MODE_EXPERIMENT_MULTI_PRERENDER_GROUP:
- config_.max_link_concurrency = 4;
- config_.max_link_concurrency_per_launcher = 2;
- break;
- case PrerenderManager::PRERENDER_MODE_EXPERIMENT_15MIN_TTL_GROUP:
- config_.time_to_live = base::TimeDelta::FromMinutes(15);
- break;
- default:
- break;
- }
-
notification_registrar_.Add(
this, chrome::NOTIFICATION_PROFILE_DESTROYED,
content::Source<Profile>(profile_));
@@ -631,16 +618,6 @@ bool PrerenderManager::IsPrerenderingPossible() {
}
// static
-bool PrerenderManager::ActuallyPrerendering() {
- return IsPrerenderingPossible() && !IsControlGroup();
-}
-
-// static
-bool PrerenderManager::IsControlGroup() {
- return GetMode() == PRERENDER_MODE_EXPERIMENT_CONTROL_GROUP;
-}
-
-// static
bool PrerenderManager::IsNoUseGroup() {
return GetMode() == PRERENDER_MODE_EXPERIMENT_NO_USE_GROUP;
}
@@ -796,14 +773,8 @@ std::unique_ptr<base::DictionaryValue> PrerenderManager::GetAsValue() const {
dict_value->SetBoolean("omnibox_enabled", IsOmniboxEnabled(profile_));
// If prerender is disabled via a flag this method is not even called.
std::string enabled_note;
- if (IsControlGroup())
- enabled_note += "(Control group: Not actually prerendering) ";
if (IsNoUseGroup())
enabled_note += "(No-use group: Not swapping in prerendered pages) ";
- if (GetMode() == PRERENDER_MODE_EXPERIMENT_15MIN_TTL_GROUP) {
- enabled_note +=
- "(15 min TTL group: Extended prerender eviction to 15 mins) ";
- }
dict_value->SetString("enabled_note", enabled_note);
return dict_value;
}
@@ -928,8 +899,6 @@ std::unique_ptr<PrerenderHandle> PrerenderManager::AddPrerender(
GURL url = url_arg;
GURL alias_url;
- if (IsControlGroup() && MaybeGetQueryStringBasedAliasURL(url, &alias_url))
- url = alias_url;
// From here on, we will record a FinalStatus so we need to register with the
// histogram tracking.
@@ -1023,11 +992,7 @@ std::unique_ptr<PrerenderHandle> PrerenderManager::AddPrerender(
prerender_contents_ptr->StartPrerendering(contents_bounds,
session_storage_namespace);
- DCHECK(IsControlGroup() ||
- prerender_contents_ptr->prerendering_has_started());
-
- if (GetMode() == PRERENDER_MODE_EXPERIMENT_MULTI_PRERENDER_GROUP)
- histograms_->RecordConcurrency(active_prerenders_.size());
+ DCHECK(prerender_contents_ptr->prerendering_has_started());
StartSchedulingPeriodicCleanups();
return prerender_handle;
@@ -1289,7 +1254,7 @@ void PrerenderManager::OnCreatingAudioStream(int render_process_id,
void PrerenderManager::RecordNetworkBytes(Origin origin,
bool used,
int64_t prerender_bytes) {
- if (!ActuallyPrerendering())
+ if (!IsPrerenderingPossible())
return;
int64_t recent_profile_bytes =
profile_network_bytes_ - last_recorded_profile_network_bytes_;
@@ -1367,7 +1332,7 @@ NetworkPredictionStatus PrerenderManager::GetPredictionStatusForOrigin(
void PrerenderManager::AddProfileNetworkBytesIfEnabled(int64_t bytes) {
DCHECK_GE(bytes, 0);
if (GetPredictionStatus() == NetworkPredictionStatus::ENABLED &&
- ActuallyPrerendering())
+ IsPrerenderingPossible())
profile_network_bytes_ += bytes;
}

Powered by Google App Engine
This is Rietveld 408576698