Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: third_party/WebKit/Source/core/loader/resource/ImageResource.h

Issue 2527353002: Phase II Step 3: Reload LoFi/placeholder images via new ImageResource
Patch Set: Reflect comments and rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/loader/resource/ImageResource.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/loader/resource/ImageResource.h
diff --git a/third_party/WebKit/Source/core/loader/resource/ImageResource.h b/third_party/WebKit/Source/core/loader/resource/ImageResource.h
index 53082f99cfdd6f0c3e562593b718d7b49fc8d2c2..9e2170604147044821ad13f40c037015841dc96d 100644
--- a/third_party/WebKit/Source/core/loader/resource/ImageResource.h
+++ b/third_party/WebKit/Source/core/loader/resource/ImageResource.h
@@ -70,8 +70,9 @@ class CORE_EXPORT ImageResource final
ImageResourceContent* getContent();
const ImageResourceContent* getContent() const;
- void reloadIfLoFiOrPlaceholderImage(ResourceFetcher*,
- ReloadLoFiOrPlaceholderPolicy);
+ ImageResource* reloadIfLoFiOrPlaceholderImage(
+ ResourceFetcher*,
+ ReloadLoFiOrPlaceholderPolicy) override;
void didAddClient(ResourceClient*) override;
@@ -129,8 +130,6 @@ class CORE_EXPORT ImageResource final
ImageResourceContent::UpdateImageOption,
bool allDataReceived);
- void checkNotify() override;
-
void destroyDecodedDataIfPossible() override;
void destroyDecodedDataForFailedRevalidation() override;
@@ -138,6 +137,8 @@ class CORE_EXPORT ImageResource final
bool shouldReloadBrokenPlaceholder() const;
+ void detachContent();
+
Member<ImageResourceContent> m_content;
// TODO(hiroshige): move |m_devicePixelRatioHeaderValue| and
@@ -150,10 +151,6 @@ class CORE_EXPORT ImageResource final
MultipartParsingState::WaitingForFirstPart;
bool m_hasDevicePixelRatioHeaderValue;
- // Indicates if the ImageResource is currently scheduling a reload, e.g.
- // because reloadIfLoFi() was called.
- bool m_isSchedulingReload;
-
// Indicates if this ImageResource is either attempting to load a placeholder
// image, or is a (possibly broken) placeholder image.
enum class PlaceholderOption {
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/loader/resource/ImageResource.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698