Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Unified Diff: net/base/filename_util.cc

Issue 252733002: Consolidate most of net/'s icu_string_conversions.h dependencies. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Response to comments (x2) Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/base/filename_util.cc
===================================================================
--- net/base/filename_util.cc (revision 266199)
+++ net/base/filename_util.cc (working copy)
@@ -7,7 +7,6 @@
#include "base/file_util.h"
#include "base/files/file_path.h"
#include "base/i18n/file_util_icu.h"
-#include "base/i18n/icu_string_conversions.h"
#include "base/path_service.h"
#include "base/strings/string_util.h"
#include "base/strings/sys_string_conversions.h"
@@ -15,6 +14,7 @@
#include "base/threading/thread_restrictions.h"
#include "net/base/escape.h"
#include "net/base/mime_util.h"
+#include "net/base/net_string_util.h"
#include "net/http/http_content_disposition.h"
#include "url/gurl.h"
@@ -77,10 +77,9 @@
// encoding detection.
base::string16 utf16_output;
if (!referrer_charset.empty() &&
- base::CodepageToUTF16(unescaped_url_filename,
- referrer_charset.c_str(),
- base::OnStringConversionError::FAIL,
- &utf16_output)) {
+ net::ConvertToUTF16(unescaped_url_filename,
+ referrer_charset.c_str(),
+ &utf16_output)) {
decoded_filename = base::UTF16ToUTF8(utf16_output);
} else {
decoded_filename = base::WideToUTF8(

Powered by Google App Engine
This is Rietveld 408576698