Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Issue 2527323003: Add physical_web namespace (Closed)

Created:
4 years ago by Olivier
Modified:
4 years ago
Reviewers:
droger, vitaliii
CC:
chromium-reviews, pkl (ping after 24h if needed), mac-reviews_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add physical_web namespace These files are not compiled in Chromium. This is a following up of https://codereview.chromium.org/2528893003/. TBR=droger Committed: https://crrev.com/337b4870b6197fe5ffb80719161835b396df7de3 Cr-Commit-Position: refs/heads/master@{#434532}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -6 lines) Patch
M ios/chrome/browser/application_context_impl.h View 2 chunks +3 lines, -2 lines 0 comments Download
M ios/chrome/browser/physical_web/create_physical_web_data_source.h View 1 chunk +4 lines, -1 line 0 comments Download
M ios/chrome/browser/physical_web/create_physical_web_data_source.mm View 1 chunk +5 lines, -2 lines 0 comments Download
M ios/chrome/browser/physical_web/ios_chrome_physical_web_data_source.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
Olivier
4 years ago (2016-11-25 16:25:13 UTC) #2
vitaliii
lgtm
4 years ago (2016-11-25 16:27:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2527323003/1
4 years ago (2016-11-25 16:27:28 UTC) #7
droger
lgtm
4 years ago (2016-11-25 16:28:19 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-25 17:18:18 UTC) #11
commit-bot: I haz the power
4 years ago (2016-11-25 17:20:15 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/337b4870b6197fe5ffb80719161835b396df7de3
Cr-Commit-Position: refs/heads/master@{#434532}

Powered by Google App Engine
This is Rietveld 408576698