services/ui/surfaces/display_compositor.cc - Issue 2527283003: cc: Introduce BeginFrame sequence numbers and acknowledgements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/ui/surfaces/display_compositor.cc

Issue 2527283003: cc: Introduce BeginFrame sequence numbers and acknowledgements.

Patch Set: Address Sami's comments, DisplayScheduler observes while BFSObservers exist. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: services/ui/surfaces/display_compositor.cc

diff --git a/services/ui/surfaces/display_compositor.cc b/services/ui/surfaces/display_compositor.cc

index 4c4f85a980d373f0d53dd06030df0b047b8abbc5..5f503c8ed61d92f614c74af1590594097a50b31d 100644

--- a/services/ui/surfaces/display_compositor.cc

+++ b/services/ui/surfaces/display_compositor.cc

@@ -206,8 +206,7 @@ std::unique_ptr<cc::Display> DisplayCompositor::CreateDisplay(

DCHECK_GT(max_frames_pending, 0);

std::unique_ptr<cc::DisplayScheduler> scheduler(

- new cc::DisplayScheduler(synthetic_begin_frame_source.get(),

- task_runner_.get(), max_frames_pending));

+ new cc::DisplayScheduler(task_runner_.get(), max_frames_pending));

return base::MakeUnique<cc::Display>(

nullptr /* bitmap_manager */, gpu_memory_buffer_manager_.get(),