android_webview/browser/surfaces_instance.cc - Issue 2527283003: cc: Introduce BeginFrame sequence numbers and acknowledgements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/browser/surfaces_instance.cc

Issue 2527283003: cc: Introduce BeginFrame sequence numbers and acknowledgements.

Patch Set: Address Sami's comments, DisplayScheduler observes while BFSObservers exist. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: android_webview/browser/surfaces_instance.cc

diff --git a/android_webview/browser/surfaces_instance.cc b/android_webview/browser/surfaces_instance.cc

index f16fe5e0c29b7bc491eca366ff9ec3e2cecc1445..46ff27ad4a859705c638e6500f808d1825d50bdd 100644

--- a/android_webview/browser/surfaces_instance.cc

+++ b/android_webview/browser/surfaces_instance.cc

@@ -65,8 +65,7 @@ SurfacesInstance::SurfacesInstance()

DeferredGpuCommandService::GetInstance())));

output_surface_ = output_surface_holder.get();

std::unique_ptr<cc::DisplayScheduler> scheduler(new cc::DisplayScheduler(

- begin_frame_source.get(), nullptr,

- output_surface_holder->capabilities().max_frames_pending));

+ nullptr, output_surface_holder->capabilities().max_frames_pending));

display_.reset(new cc::Display(

nullptr /* shared_bitmap_manager */,

nullptr /* gpu_memory_buffer_manager */, settings, frame_sink_id_,