Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Side by Side Diff: cc/surfaces/display_begin_frame_source.cc

Issue 2527283003: cc: Introduce BeginFrame sequence numbers and acknowledgements.
Patch Set: Address Brian's comments. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/surfaces/display_begin_frame_source.h ('k') | cc/surfaces/display_scheduler.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "cc/surfaces/display_begin_frame_source.h"
6
7 #include <algorithm>
8
9 namespace cc {
10
11 DisplayBeginFrameSource::DisplayBeginFrameSource(
12 std::unique_ptr<BeginFrameSource> wrapped_source)
13 : wrapped_source_(std::move(wrapped_source)),
14 observing_begin_frames_(false),
15 frame_active_(false),
16 latest_confirmed_frame_(BeginFrameArgs::kInvalidFrameNumber),
17 client_(nullptr),
18 client_needs_begin_frames_(false) {}
19
20 DisplayBeginFrameSource::~DisplayBeginFrameSource() {
21 if (wrapped_source_ && observing_begin_frames_)
22 wrapped_source_->RemoveObserver(this);
23 }
24
25 void DisplayBeginFrameSource::SetClient(DisplayBeginFrameSourceClient* client) {
26 client_ = client;
27 ObserverStatusChanged();
28 }
29
30 void DisplayBeginFrameSource::SetClientNeedsBeginFrames(
31 bool needs_begin_frames) {
32 DCHECK(client_);
33
34 if (client_needs_begin_frames_ == needs_begin_frames)
35 return;
36 client_needs_begin_frames_ = needs_begin_frames;
37
38 if (client_needs_begin_frames_ && observing_begin_frames_) {
39 // We were already observing, but the client may have missed the last
40 // BeginFrame.
41 BeginFrameArgs missed_args =
42 GetMissedArgs(client_->LastUsedBeginFrameArgs());
43 if (missed_args.IsValid())
44 client_->OnBeginFrame(missed_args);
45 }
46
47 UpdateObservingBeginFrames();
48 }
49
50 void DisplayBeginFrameSource::FinishClientFrame(bool had_damage,
51 bool has_pending_updates) {
52 DCHECK(frame_active_);
53 frame_active_ = false;
54
55 // Only update the |latest_confirmed_frame_| if there are no further pending
56 // updates (i.e. the Display didn't have to draw or drew successfully).
57 if (!has_pending_updates)
58 latest_confirmed_frame_ = ack_tracker_.LatestConfirmedFrame();
59
60 BeginFrameAck ack(current_begin_frame_args_.source_id,
61 current_begin_frame_args_.sequence_number,
62 latest_confirmed_frame_, 0, had_damage);
63 if (wrapped_source_)
64 wrapped_source_->DidFinishFrame(this, ack);
65 }
66
67 bool DisplayBeginFrameSource::HasObservers() const {
68 return !observers_.empty();
69 }
70
71 bool DisplayBeginFrameSource::AllObserversFinishedFrame() const {
72 return ack_tracker_.AllObserversFinishedFrame();
73 }
74
75 void DisplayBeginFrameSource::SwapWrappedSource(
76 std::unique_ptr<BeginFrameSource>* begin_frame_source) {
77 if (wrapped_source_ && observing_begin_frames_)
78 wrapped_source_->RemoveObserver(this);
79
80 wrapped_source_.swap(*begin_frame_source);
81
82 if (wrapped_source_ && observing_begin_frames_)
83 wrapped_source_->AddObserver(this);
84 }
85
86 uint64_t DisplayBeginFrameSource::CurrentSourceId() {
87 return current_begin_frame_args_.source_id;
88 }
89
90 uint64_t DisplayBeginFrameSource::CurrentFrameNumber() {
91 return current_begin_frame_args_.sequence_number;
92 }
93
94 uint64_t DisplayBeginFrameSource::LatestConfirmedFrame() {
95 return ack_tracker_.LatestConfirmedFrame();
96 }
97
98 void DisplayBeginFrameSource::DidFinishFrame(BeginFrameObserver* obs,
99 const BeginFrameAck& ack) {
100 ack_tracker_.OnObserverFinishedFrame(obs, ack);
101 ObserverStatusChanged();
102 }
103
104 void DisplayBeginFrameSource::AddObserver(BeginFrameObserver* obs) {
105 observers_.insert(obs);
106 ack_tracker_.OnObserverAdded(obs);
107
108 ObserverStatusChanged();
109
110 if (observing_begin_frames_) {
111 // We were already observing, but the observer may have missed the last
112 // BeginFrame.
113 BeginFrameArgs missed_args = GetMissedArgs(obs->LastUsedBeginFrameArgs());
114 if (missed_args.IsValid()) {
115 obs->OnBeginFrame(missed_args);
116 ack_tracker_.OnObserverBeginFrame(obs, missed_args);
117 }
118 }
119
120 UpdateObservingBeginFrames();
121 }
122
123 void DisplayBeginFrameSource::RemoveObserver(BeginFrameObserver* obs) {
124 observers_.erase(obs);
125 ack_tracker_.OnObserverRemoved(obs);
126
127 ObserverStatusChanged();
128 UpdateObservingBeginFrames();
129 }
130
131 bool DisplayBeginFrameSource::IsThrottled() const {
132 if (wrapped_source_)
133 return wrapped_source_->IsThrottled();
134 return true;
135 }
136
137 void DisplayBeginFrameSource::OnBeginFrame(const BeginFrameArgs& args) {
138 if (client_ && client_needs_begin_frames_)
139 client_->OnBeginFrame(args);
140
141 // Reset for the new frame.
142 frame_active_ = true;
143 ack_tracker_.OnBeginFrame(args);
144
145 // BeginFrameObserverAckTracker will have updated the latest confirmed frame
146 // if the wrapped source changes.
147 if (args.source_id != current_begin_frame_args_.source_id)
148 latest_confirmed_frame_ = ack_tracker_.LatestConfirmedFrame();
149
150 current_begin_frame_args_ = args;
151
152 // Observers may remove themselves during OnBeginFrame(), so use a copy.
153 std::set<BeginFrameObserver*> observers = observers_;
154 for (BeginFrameObserver* obs : observers) {
155 obs->OnBeginFrame(args);
156 ack_tracker_.OnObserverBeginFrame(obs, args);
157 }
158
159 ObserverStatusChanged();
160 }
161
162 const BeginFrameArgs& DisplayBeginFrameSource::LastUsedBeginFrameArgs() const {
163 return current_begin_frame_args_;
164 }
165
166 void DisplayBeginFrameSource::OnBeginFrameSourcePausedChanged(bool paused) {
167 // BeginFrameSources used as wrapped sources do not make use of this feature.
168 DCHECK(!paused);
169 }
170
171 void DisplayBeginFrameSource::UpdateObservingBeginFrames() {
172 bool should_observe = client_needs_begin_frames_ || !observers_.empty();
173 if (should_observe == observing_begin_frames_)
174 return;
175
176 observing_begin_frames_ = should_observe;
177
178 if (!wrapped_source_)
179 return;
180
181 if (observing_begin_frames_) {
182 // We need to start observing, a missed BeginFrame will be triggered by
183 // the wrapped source and forwarded to the client or observer.
184 wrapped_source_->AddObserver(this);
185 } else {
186 wrapped_source_->RemoveObserver(this);
187 }
188 }
189
190 BeginFrameArgs DisplayBeginFrameSource::GetMissedArgs(
191 const BeginFrameArgs& last_args) const {
192 if (!current_begin_frame_args_.IsValid() || !wrapped_source_ ||
193 !frame_active_)
194 return BeginFrameArgs();
195
196 if (last_args.IsValid() &&
197 (last_args.sequence_number >= current_begin_frame_args_.sequence_number))
198 return BeginFrameArgs();
199
200 BeginFrameArgs missed_args = current_begin_frame_args_;
201 missed_args.type = BeginFrameArgs::MISSED;
202 return missed_args;
203 }
204
205 void DisplayBeginFrameSource::ObserverStatusChanged() {
206 if (client_)
207 client_->BeginFrameObserverStatusChanged();
208 }
209
210 } // namespace cc
OLDNEW
« no previous file with comments | « cc/surfaces/display_begin_frame_source.h ('k') | cc/surfaces/display_scheduler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698