Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(657)

Side by Side Diff: cc/surfaces/display.cc

Issue 2527283003: cc: Introduce BeginFrame sequence numbers and acknowledgements.
Patch Set: Address Brian's comments. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/surfaces/display.h ('k') | cc/surfaces/display_begin_frame_source.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/surfaces/display.h" 5 #include "cc/surfaces/display.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include "base/memory/ptr_util.h" 9 #include "base/memory/ptr_util.h"
10 #include "base/trace_event/trace_event.h" 10 #include "base/trace_event/trace_event.h"
11 #include "cc/debug/benchmark_instrumentation.h" 11 #include "cc/debug/benchmark_instrumentation.h"
12 #include "cc/output/compositor_frame.h" 12 #include "cc/output/compositor_frame.h"
13 #include "cc/output/direct_renderer.h" 13 #include "cc/output/direct_renderer.h"
14 #include "cc/output/gl_renderer.h" 14 #include "cc/output/gl_renderer.h"
15 #include "cc/output/output_surface_frame.h"
15 #include "cc/output/renderer_settings.h" 16 #include "cc/output/renderer_settings.h"
16 #include "cc/output/software_renderer.h" 17 #include "cc/output/software_renderer.h"
17 #include "cc/output/texture_mailbox_deleter.h" 18 #include "cc/output/texture_mailbox_deleter.h"
18 #include "cc/scheduler/begin_frame_source.h" 19 #include "cc/scheduler/begin_frame_source.h"
19 #include "cc/surfaces/display_client.h" 20 #include "cc/surfaces/display_client.h"
20 #include "cc/surfaces/display_scheduler.h" 21 #include "cc/surfaces/display_scheduler.h"
21 #include "cc/surfaces/surface.h" 22 #include "cc/surfaces/surface.h"
22 #include "cc/surfaces/surface_aggregator.h" 23 #include "cc/surfaces/surface_aggregator.h"
23 #include "cc/surfaces/surface_manager.h" 24 #include "cc/surfaces/surface_manager.h"
24 #include "gpu/command_buffer/client/gles2_interface.h" 25 #include "gpu/command_buffer/client/gles2_interface.h"
(...skipping 10 matching lines...) Expand all
35 const RendererSettings& settings, 36 const RendererSettings& settings,
36 const FrameSinkId& frame_sink_id, 37 const FrameSinkId& frame_sink_id,
37 std::unique_ptr<BeginFrameSource> begin_frame_source, 38 std::unique_ptr<BeginFrameSource> begin_frame_source,
38 std::unique_ptr<OutputSurface> output_surface, 39 std::unique_ptr<OutputSurface> output_surface,
39 std::unique_ptr<DisplayScheduler> scheduler, 40 std::unique_ptr<DisplayScheduler> scheduler,
40 std::unique_ptr<TextureMailboxDeleter> texture_mailbox_deleter) 41 std::unique_ptr<TextureMailboxDeleter> texture_mailbox_deleter)
41 : bitmap_manager_(bitmap_manager), 42 : bitmap_manager_(bitmap_manager),
42 gpu_memory_buffer_manager_(gpu_memory_buffer_manager), 43 gpu_memory_buffer_manager_(gpu_memory_buffer_manager),
43 settings_(settings), 44 settings_(settings),
44 frame_sink_id_(frame_sink_id), 45 frame_sink_id_(frame_sink_id),
45 begin_frame_source_(std::move(begin_frame_source)), 46 begin_frame_source_(
47 new DisplayBeginFrameSource(std::move(begin_frame_source))),
46 output_surface_(std::move(output_surface)), 48 output_surface_(std::move(output_surface)),
47 scheduler_(std::move(scheduler)), 49 scheduler_(std::move(scheduler)),
48 texture_mailbox_deleter_(std::move(texture_mailbox_deleter)) { 50 texture_mailbox_deleter_(std::move(texture_mailbox_deleter)) {
49 DCHECK(output_surface_); 51 DCHECK(output_surface_);
50 DCHECK_EQ(!scheduler_, !begin_frame_source_); 52 DCHECK_EQ(!scheduler_, !begin_frame_source_->GetWrappedSource());
51 DCHECK(frame_sink_id_.is_valid()); 53 DCHECK(frame_sink_id_.is_valid());
52 if (scheduler_) 54 if (scheduler_) {
53 scheduler_->SetClient(this); 55 scheduler_->SetClient(this);
56 scheduler_->SetBeginFrameSource(begin_frame_source_.get());
57 }
54 } 58 }
55 59
56 Display::~Display() { 60 Display::~Display() {
57 // Only do this if Initialize() happened. 61 // Only do this if Initialize() happened.
58 if (client_) { 62 if (client_) {
59 if (auto* context = output_surface_->context_provider()) 63 if (auto* context = output_surface_->context_provider())
60 context->SetLostContextCallback(base::Closure()); 64 context->SetLostContextCallback(base::Closure());
61 if (begin_frame_source_) 65 surface_manager_->UnregisterBeginFrameSource(begin_frame_source_.get());
62 surface_manager_->UnregisterBeginFrameSource(begin_frame_source_.get());
63 surface_manager_->RemoveObserver(this); 66 surface_manager_->RemoveObserver(this);
64 } 67 }
65 if (aggregator_) { 68 if (aggregator_) {
66 for (const auto& id_entry : aggregator_->previous_contained_surfaces()) { 69 for (const auto& id_entry : aggregator_->previous_contained_surfaces()) {
67 Surface* surface = surface_manager_->GetSurfaceForId(id_entry.first); 70 Surface* surface = surface_manager_->GetSurfaceForId(id_entry.first);
68 if (surface) 71 if (surface)
69 surface->RunDrawCallbacks(); 72 surface->RunDrawCallbacks();
70 } 73 }
71 } 74 }
72 } 75 }
73 76
74 void Display::Initialize(DisplayClient* client, 77 void Display::Initialize(DisplayClient* client,
75 SurfaceManager* surface_manager) { 78 SurfaceManager* surface_manager) {
76 DCHECK(client); 79 DCHECK(client);
77 DCHECK(surface_manager); 80 DCHECK(surface_manager);
78 client_ = client; 81 client_ = client;
79 surface_manager_ = surface_manager; 82 surface_manager_ = surface_manager;
80 83
81 surface_manager_->AddObserver(this); 84 surface_manager_->AddObserver(this);
82 85
83 // This must be done in Initialize() so that the caller can delay this until 86 // This must be done in Initialize() so that the caller can delay this until
84 // they are ready to receive a BeginFrameSource. 87 // they are ready to receive a BeginFrameSource.
85 if (begin_frame_source_) { 88 surface_manager_->RegisterBeginFrameSource(begin_frame_source_.get(),
86 surface_manager_->RegisterBeginFrameSource(begin_frame_source_.get(), 89 frame_sink_id_);
87 frame_sink_id_);
88 }
89 90
90 output_surface_->BindToClient(this); 91 output_surface_->BindToClient(this);
91 InitializeRenderer(); 92 InitializeRenderer();
92 93
93 if (auto* context = output_surface_->context_provider()) { 94 if (auto* context = output_surface_->context_provider()) {
94 // This depends on assumptions that Display::Initialize will happen 95 // This depends on assumptions that Display::Initialize will happen
95 // on the same callstack as the ContextProvider being created/initialized 96 // on the same callstack as the ContextProvider being created/initialized
96 // or else it could miss a callback before setting this. 97 // or else it could miss a callback before setting this.
97 context->SetLostContextCallback(base::Bind( 98 context->SetLostContextCallback(base::Bind(
98 &Display::DidLoseContextProvider, 99 &Display::DidLoseContextProvider,
(...skipping 222 matching lines...) Expand 10 before | Expand all | Expand 10 after
321 if (should_swap) { 322 if (should_swap) {
322 swapped_since_resize_ = true; 323 swapped_since_resize_ = true;
323 for (auto& latency : frame.metadata.latency_info) { 324 for (auto& latency : frame.metadata.latency_info) {
324 TRACE_EVENT_WITH_FLOW1( 325 TRACE_EVENT_WITH_FLOW1(
325 "input,benchmark", "LatencyInfo.Flow", 326 "input,benchmark", "LatencyInfo.Flow",
326 TRACE_ID_DONT_MANGLE(latency.trace_id()), 327 TRACE_ID_DONT_MANGLE(latency.trace_id()),
327 TRACE_EVENT_FLAG_FLOW_IN | TRACE_EVENT_FLAG_FLOW_OUT, "step", 328 TRACE_EVENT_FLAG_FLOW_IN | TRACE_EVENT_FLAG_FLOW_OUT, "step",
328 "Display::DrawAndSwap"); 329 "Display::DrawAndSwap");
329 } 330 }
330 benchmark_instrumentation::IssueDisplayRenderingStatsEvent(); 331 benchmark_instrumentation::IssueDisplayRenderingStatsEvent();
331 renderer_->SwapBuffers(std::move(frame.metadata.latency_info)); 332 OutputSurfaceFrame output_frame;
333 output_frame.latency_info = std::move(frame.metadata.latency_info);
334 // Pass on frame number information through |output_frame| for output
335 // surfaces that acknowledge the frame to an external BeginFrameSource.
336 output_frame.begin_frame_source_id = begin_frame_source_->CurrentSourceId();
337 output_frame.begin_frame_number = begin_frame_source_->CurrentFrameNumber();
338 output_frame.begin_frame_number =
339 begin_frame_source_->LatestConfirmedFrame();
340 renderer_->SwapBuffers(std::move(output_frame));
332 if (scheduler_) 341 if (scheduler_)
333 scheduler_->DidSwapBuffers(); 342 scheduler_->DidSwapBuffers();
334 } else { 343 } else {
335 if (have_damage && !size_matches) 344 if (have_damage && !size_matches)
336 aggregator_->SetFullDamageForSurface(current_surface_id_); 345 aggregator_->SetFullDamageForSurface(current_surface_id_);
337 TRACE_EVENT_INSTANT0("cc", "Swap skipped.", TRACE_EVENT_SCOPE_THREAD); 346 TRACE_EVENT_INSTANT0("cc", "Swap skipped.", TRACE_EVENT_SCOPE_THREAD);
338 stored_latency_info_.insert(stored_latency_info_.end(), 347 stored_latency_info_.insert(stored_latency_info_.end(),
339 frame.metadata.latency_info.begin(), 348 frame.metadata.latency_info.begin(),
340 frame.metadata.latency_info.end()); 349 frame.metadata.latency_info.end());
341 if (scheduler_) { 350 if (scheduler_) {
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
396 405
397 const SurfaceId& Display::CurrentSurfaceId() { 406 const SurfaceId& Display::CurrentSurfaceId() {
398 return current_surface_id_; 407 return current_surface_id_;
399 } 408 }
400 409
401 void Display::ForceImmediateDrawAndSwapIfPossible() { 410 void Display::ForceImmediateDrawAndSwapIfPossible() {
402 if (scheduler_) 411 if (scheduler_)
403 scheduler_->ForceImmediateSwapIfPossible(); 412 scheduler_->ForceImmediateSwapIfPossible();
404 } 413 }
405 414
415 void Display::SwapBeginFrameSource(
416 std::unique_ptr<BeginFrameSource>* begin_frame_source) {
417 begin_frame_source_->SwapWrappedSource(begin_frame_source);
418 }
419
406 } // namespace cc 420 } // namespace cc
OLDNEW
« no previous file with comments | « cc/surfaces/display.h ('k') | cc/surfaces/display_begin_frame_source.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698