Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1515)

Side by Side Diff: cc/ipc/mojo_compositor_frame_sink.mojom

Issue 2527283003: cc: Introduce BeginFrame sequence numbers and acknowledgements.
Patch Set: Address Brian's comments. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/ipc/cc_param_traits_macros.h ('k') | cc/output/begin_frame_args.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 module cc.mojom; 5 module cc.mojom;
6 6
7 import "cc/ipc/begin_frame_args.mojom"; 7 import "cc/ipc/begin_frame_args.mojom";
8 import "cc/ipc/compositor_frame.mojom"; 8 import "cc/ipc/compositor_frame.mojom";
9 import "cc/ipc/frame_sink_id.mojom"; 9 import "cc/ipc/frame_sink_id.mojom";
10 import "cc/ipc/local_frame_id.mojom"; 10 import "cc/ipc/local_frame_id.mojom";
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
46 // TODO(staraz): Delete Require() and Satisfy() once surface references 46 // TODO(staraz): Delete Require() and Satisfy() once surface references
47 // (CL 2541683004) are ready. 47 // (CL 2541683004) are ready.
48 // Add the provided |sequence| as a destruction dependency of the 48 // Add the provided |sequence| as a destruction dependency of the
49 // surface associated with the provided |local_frame_id|. 49 // surface associated with the provided |local_frame_id|.
50 Require(cc.mojom.LocalFrameId local_frame_id, 50 Require(cc.mojom.LocalFrameId local_frame_id,
51 cc.mojom.SurfaceSequence sequence); 51 cc.mojom.SurfaceSequence sequence);
52 52
53 // Mark the sequence as satisfied and garbage collect surfaces. 53 // Mark the sequence as satisfied and garbage collect surfaces.
54 Satisfy(cc.mojom.SurfaceSequence sequence); 54 Satisfy(cc.mojom.SurfaceSequence sequence);
55 55
56 // Notifies the frame sink that a BeginFrame was completed, but that no
57 // CompositorFrame was produced as a result of it.
58 BeginFrameDidNotDraw(BeginFrameAck ack);
59
56 // TODO(fsamuel): ReadbackBitmap API would be useful here. 60 // TODO(fsamuel): ReadbackBitmap API would be useful here.
57 }; 61 };
58 62
59 interface MojoCompositorFrameSinkClient { 63 interface MojoCompositorFrameSinkClient {
60 // Notification that the previous CompositorFrame given to 64 // Notification that the previous CompositorFrame given to
61 // SubmitCompositorFrame() has been processed and that another frame 65 // SubmitCompositorFrame() has been processed and that another frame
62 // can be submitted. This provides backpressure from the display compositor 66 // can be submitted. This provides backpressure from the display compositor
63 // so that frames are submitted only at the rate it can handle them. 67 // so that frames are submitted only at the rate it can handle them.
64 // TODO(fsamuel): This method ought not be necessary with unified BeginFrame. 68 // TODO(fsamuel): This method ought not be necessary with unified BeginFrame.
65 // However, there's a fair amount of cleanup and refactoring necessary to get 69 // However, there's a fair amount of cleanup and refactoring necessary to get
(...skipping 11 matching lines...) Expand all
77 }; 81 };
78 82
79 // MojoCompositorFrameSinkPrivate is used by the display compositor host to set 83 // MojoCompositorFrameSinkPrivate is used by the display compositor host to set
80 // up BeginFrameSource hierarchies. This API lives in SurfaceManager but is 84 // up BeginFrameSource hierarchies. This API lives in SurfaceManager but is
81 // called from here in order to ensure that hierarchy registration does not race 85 // called from here in order to ensure that hierarchy registration does not race
82 // CompositorFrameSink creation. 86 // CompositorFrameSink creation.
83 interface MojoCompositorFrameSinkPrivate { 87 interface MojoCompositorFrameSinkPrivate {
84 AddChildFrameSink(FrameSinkId child_frame_sink_id); 88 AddChildFrameSink(FrameSinkId child_frame_sink_id);
85 RemoveChildFrameSink(FrameSinkId child_frame_sink_id); 89 RemoveChildFrameSink(FrameSinkId child_frame_sink_id);
86 }; 90 };
OLDNEW
« no previous file with comments | « cc/ipc/cc_param_traits_macros.h ('k') | cc/output/begin_frame_args.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698