Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 2527273003: WebRtcBrowserTest: Include all stats in getStats. (Closed)

Created:
4 years ago by hbos_chromium
Modified:
4 years ago
Reviewers:
phoglund_chromium
CC:
chromium-reviews, feature-media-reviews_chromium.org, phoglund+watch_chromium.org, mcasas+watch+vc_chromium.org, hta - Chromium
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

WebRtcBrowserTest: Include all stats in getStats. The only stats dictionary that was missing was 'data-channel'. For it to be included data channels had to be created. Added CreateDataChannel to webrtc_browsertest_base.h/cc and peerconnection.js. Unittest updated to EXPECT that no expected stats are missing. BUG=chromium:627816 Committed: https://crrev.com/39ce516e1f6da7816c8794b4fab334230a9c84ce Cr-Commit-Position: refs/heads/master@{#434502}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -3 lines) Patch
M chrome/browser/media/webrtc/webrtc_browsertest.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/media/webrtc/webrtc_browsertest_base.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/media/webrtc/webrtc_browsertest_base.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/test/data/webrtc/peerconnection.js View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
hbos_chromium
Please take a look, phoglund.
4 years ago (2016-11-25 13:12:04 UTC) #2
phoglund_chromium
lgtm
4 years ago (2016-11-25 14:33:46 UTC) #5
hbos_chromium
cc: hta (who is OOO for the day)
4 years ago (2016-11-25 14:38:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2527273003/1
4 years ago (2016-11-25 14:39:09 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-25 14:52:01 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/39ce516e1f6da7816c8794b4fab334230a9c84ce Cr-Commit-Position: refs/heads/master@{#434502}
4 years ago (2016-11-25 14:54:46 UTC) #13
bokan
On 2016/11/25 14:54:46, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as ...
4 years ago (2016-11-26 18:29:38 UTC) #14
Sam McNally
4 years ago (2016-11-27 23:06:22 UTC) #15
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2528253002/ by sammc@chromium.org.

The reason for reverting is: Failing on desktop platforms:
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.linux%2FLinux_T....

Powered by Google App Engine
This is Rietveld 408576698