Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1311)

Issue 2527263004: [bisect] - Have compare_samples check for missing "summary" tracename. (Closed)

Created:
4 years ago by shatch
Modified:
4 years ago
CC:
catapult-reviews_chromium.org, tracing-review_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

[bisect] - Have compare_samples check for missing "summary" tracename. The dashboard actually strips this on upload, so when reconstructing the full metric name for metrics with a tir_label, we can fallback to looking for a summary. BUG=chromium:668536 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/59c9c1d73830c7d187d54836f3776cda4b9a2b30

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -2 lines) Patch
M tracing/tracing/metrics/compare_samples_cmdline.html View 3 chunks +23 lines, -2 lines 0 comments Download
M tracing/tracing/metrics/compare_samples_unittest.py View 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
shatch
4 years ago (2016-11-29 15:24:32 UTC) #3
shatch
Ethan do you mind taking a look, Roberto is out and this is blocking some ...
4 years ago (2016-11-30 15:34:22 UTC) #5
sullivan
lgtm
4 years ago (2016-11-30 15:38:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2527263004/1
4 years ago (2016-11-30 15:40:36 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: Catapult Presubmit on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Presubmit/builds/5261)
4 years ago (2016-11-30 15:43:28 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2527263004/1
4 years ago (2016-11-30 15:49:45 UTC) #14
commit-bot: I haz the power
4 years ago (2016-11-30 16:02:42 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698