Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 2527233003: [Prerender] Add a "SimpleLoad" mode to be used as a comparison reference (Closed)

Created:
4 years ago by droger
Modified:
4 years ago
Reviewers:
pasko, mattcary
CC:
chromium-reviews, tburkard+watch_chromium.org, gavinp+prer_chromium.org, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Prerender] Add a "SimpleLoad" mode to be used as a comparison reference This CL introduces the SIMPLE_LOAD_EXPERIMENT prerender mode. In this mode, no prerendering or prefetching happens, but the URLs that would have been prefetched are recorded, and UMA metrics are reported. This will be used as a reference point to evaluate the speed improvements of prerendering and prefetching. For now both the simple load mode and the prefetch mode record the FCP histograms. Prerender will have to be updated to record these histograms as well in another CL. BUG=668997 Committed: https://crrev.com/88ffbf898da32332e9e592954d45ddccffbe89a1 Cr-Commit-Position: refs/heads/master@{#434633}

Patch Set 1 : add command line flag #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -4 lines) Patch
M chrome/browser/prerender/prerender_field_trial.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/prerender/prerender_manager.h View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/prerender/prerender_manager.cc View 3 chunks +15 lines, -3 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 19 (9 generated)
droger
4 years ago (2016-11-25 16:26:38 UTC) #5
mattcary
This still won't quite do what we want, because the nostate observer isn't attached to ...
4 years ago (2016-11-28 09:28:23 UTC) #6
droger
On 2016/11/28 09:28:23, mattcary wrote: > This still won't quite do what we want, because ...
4 years ago (2016-11-28 09:47:40 UTC) #7
mattcary
lgtm Agreed.
4 years ago (2016-11-28 09:48:19 UTC) #8
pasko
lgtm the reference to 'nostate observer' was a little cryptic. I have read your guys' ...
4 years ago (2016-11-28 10:26:49 UTC) #9
mattcary
On 2016/11/28 10:26:49, pasko wrote: > lgtm > > the reference to 'nostate observer' was ...
4 years ago (2016-11-28 10:28:17 UTC) #10
droger
Thanks for the reviews, and sorry for the sloppy comments.
4 years ago (2016-11-28 10:37:31 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2527233003/40001
4 years ago (2016-11-28 10:38:10 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years ago (2016-11-28 11:19:57 UTC) #17
commit-bot: I haz the power
4 years ago (2016-11-28 11:21:47 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/88ffbf898da32332e9e592954d45ddccffbe89a1
Cr-Commit-Position: refs/heads/master@{#434633}

Powered by Google App Engine
This is Rietveld 408576698