Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 2527173002: [runtime] Add missing @@IsConcatSpreadable check for FAST_DOUBLE_ELEMENTS (Closed)

Created:
4 years ago by Camillo Bruni
Modified:
4 years ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Add missing @@IsConcatSpreadable check for FAST_DOUBLE_ELEMENTS A missing @@IsConcatSpreadable check caused the fast path inside the slow path to be incorrect and follow the default concat strategy when the arguments arrays contain only doubles. BUG=chromium:668414 Committed: https://crrev.com/a09e5eda26d9cfe4c71d42b34bc1944c527e60bf Cr-Commit-Position: refs/heads/master@{#41301}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -2 lines) Patch
M src/builtins/builtins-array.cc View 1 chunk +3 lines, -2 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-668414.js View 1 chunk +58 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Camillo Bruni
PTAL
4 years ago (2016-11-24 13:14:53 UTC) #4
Igor Sheludko
lgtm
4 years ago (2016-11-25 17:08:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2527173002/1
4 years ago (2016-11-28 09:39:37 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-28 10:06:13 UTC) #11
commit-bot: I haz the power
4 years ago (2016-11-28 10:06:22 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a09e5eda26d9cfe4c71d42b34bc1944c527e60bf
Cr-Commit-Position: refs/heads/master@{#41301}

Powered by Google App Engine
This is Rietveld 408576698