Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2318)

Unified Diff: chrome/browser/printing/background_printing_manager.cc

Issue 2527133002: Remove some WebContents::GetRenderViewHost() calls. (Closed)
Patch Set: More reverts for the same reason as patch set 3, fixes merge conflict Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/printing/background_printing_manager.cc
diff --git a/chrome/browser/printing/background_printing_manager.cc b/chrome/browser/printing/background_printing_manager.cc
index db1e39aa940e49223c915d733254b7f63afa4c7a..2807c0f87807f1efb66e44efd9c0ef95a7b7105e 100644
--- a/chrome/browser/printing/background_printing_manager.cc
+++ b/chrome/browser/printing/background_printing_manager.cc
@@ -112,8 +112,9 @@ void BackgroundPrintingManager::DeletePreviewContents(
content::Source<WebContents>(preview_contents));
printing_contents_map_.erase(i);
- // ... and mortally wound the contents. (Deletion immediately is not a good
- // idea in case this was called from RenderViewGone.)
+ // ... and mortally wound the contents. Deletion immediately is not a good
+ // idea in case this was triggered by |preview_contents| far up the
+ // callstack. (Trace where the NOTIFICATION_PRINT_JOB_RELEASED comes from.)
base::ThreadTaskRunnerHandle::Get()->DeleteSoon(FROM_HERE, preview_contents);
}

Powered by Google App Engine
This is Rietveld 408576698