Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(787)

Unified Diff: Source/core/frame/UseCounter.cpp

Issue 252713004: Make default for deep parameter in importNode false (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Use countDeprecation Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« Source/core/frame/UseCounter.h ('K') | « Source/core/frame/UseCounter.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/frame/UseCounter.cpp
diff --git a/Source/core/frame/UseCounter.cpp b/Source/core/frame/UseCounter.cpp
index ead539dbcf924b3aacf8b8c3dbede2b9d6d4fd70..e35d4b0d1ac6d19b7300e8a8d365069dcc5117cb 100644
--- a/Source/core/frame/UseCounter.cpp
+++ b/Source/core/frame/UseCounter.cpp
@@ -712,6 +712,10 @@ String UseCounter::deprecationMessage(Feature feature)
case ElementSetAttributeNodeNS:
return "'Element.setAttributeNodeNS' is deprecated and has been removed from DOM4 (http://w3.org/tr/dom).";
+ case DocumentImportNodeOptionalArgument:
+ return "The behavior of importNode() with no boolean argument is about to change from doing a deep clone to doing a shallow clone. "
+ "Make sure to pass an explicit boolean argument to keep your current behavior.";
+
// Features that aren't deprecated don't have a deprecation message.
default:
return String();
« Source/core/frame/UseCounter.h ('K') | « Source/core/frame/UseCounter.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698